Re: Compile error in current CVS, src/server.c:5500

[Mark D. Baushke]

Hi Pavel,

Actually, your patch is not yet consistent with the need to deal with
pre-ANSI compilers (altough much of those requirements appear to have
been dropped recently). In any case, the error needs to be structured a
bit differently with the 'error' keyword on the second line and return
value provided as well.

To be honest, I wonder why the result of pam_end() is not being captured
and causing a call to pam_strerror().

I think that Derek Price or Brian Murphy need to resolve how they want
this to be handled. So, I'll let them worry about it. Thanks for your
bug report.

        Enjoy!
        -- Mark

Index: server.c
===================================================================
RCS file: /cvs/ccvs/src/server.c,v
retrieving revision 1.301
diff -u -p -r1.301 server.c
--- server.c    20 Jul 2003 16:38:55 -0000      1.301
+++ server.c    20 Jul 2003 22:36:20 -0000
@@ -5497,8 +5497,8 @@ check_system_password (username, passwor
 
     if (pam_end(pamh,retval) != PAM_SUCCESS)
     {
-       printf("E Fatal error, aborting.\n
-               pam failed to release authenticator\n");
+       printf("E Fatal error, aborting.\n\
+error EACCES pam failed to release authenticator\n");
        error_exit ();
     }
 



Pavel Roskin <proski@gnu.org> writes:

> Hello!
> 
> The current CVS doesn't compile with gcc-3.3:
> server.c:5500:16: missing terminating " character
> server.c:5501:54: missing terminating " character
> 
> Fix:
> ======================================
> --- src/server.c
> +++ src/server.c
> @@ -5497,8 +5497,8 @@ check_system_password (username, passwor
> 
>      if (pam_end(pamh,retval) != PAM_SUCCESS)
>      {
> -     printf("E Fatal error, aborting.\n
> -             pam failed to release authenticator\n");
> +     printf("E Fatal error, aborting.\n"
> +             "pam failed to release authenticator\n");
>       error_exit ();
>      }
> 
> ======================================
> 
> -- 
> Regards,
> Pavel Roskin
> 
> 
> 
> _______________________________________________
> Bug-cvs mailing list
> Bug-cvs@gnu.org
> http://mail.gnu.org/mailman/listinfo/bug-cvs
>