[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: commitlog

From: Brian Murphy
Subject: Re: commitlog
Date: Wed, 13 Aug 2003 09:39:57 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030529

Mark D. Baushke wrote:

Anthon van der Neut <AvanderNeut@pinnaclesys.com> writes:

This is against, I am trying to get it make it in the official
release, so I can stop worrying to break or processing on each upgrade of
the servers. Comments and critique are welcome, pointers on who to ask to
apply this patch as well.

diff -u -r1.70 logmsg.c
--- logmsg.c    23 Jul 2003 20:42:26 -0000      1.70
+++ logmsg.c    13 Aug 2003 03:58:53 -0000
@@ -882,6 +882,9 @@
       cp += fmt_percent - filter;
       *cp++ = '"';
       cp = shell_escape (cp, srepos);
+       cp++ = '"';
+       cp++ = ' ';
+       cp++ = '"';
       cp = shell_escape (cp, str_list);
       *cp++ = '"';
       (void) strcpy (cp, fmt_continue);


Please provide test cases for src/sanity.sh and a ChangeLog entry.

        -- Mark

Bug-cvs mailing list

I sent this patch a long time ago to fix the same problem but even
though I begged I got no comments ;-).

I pass the repository name and each item generated from %{...}
as a seperate argument:


I think the argument against such things is that it will break already
running scripts. Perhaps a command line argument should signal the
new format?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]