Re: commitlog

[Brian Murphy]

Mark D. Baushke wrote:

> Anthon van der Neut <AvanderNeut@pinnaclesys.com> writes:
>
>  
>
> > This is against 1.12.1.1, I am trying to get it make it in the official
> > release, so I can stop worrying to break or processing on each upgrade of
> > the servers. Comments and critique are welcome, pointers on who to ask to
> > apply this patch as well.
> >
> > diff -u -r1.70 logmsg.c
> > --- logmsg.c    23 Jul 2003 20:42:26 -0000      1.70
> > +++ logmsg.c    13 Aug 2003 03:58:53 -0000
> > @@ -882,6 +882,9 @@
> >        cp += fmt_percent - filter;
> >        *cp++ = '"';
> >        cp = shell_escape (cp, srepos);
> > +       cp++ = '"';
> > +       cp++ = ' ';
> > +       cp++ = '"';
> >        cp = shell_escape (cp, str_list);
> >        *cp++ = '"';
> >        (void) strcpy (cp, fmt_continue);
> >
> > Regards
> > Anthon
> >    
>
> Please provide test cases for src/sanity.sh and a ChangeLog entry.
>
>         -- Mark
>
>
> _______________________________________________
> Bug-cvs mailing list
> Bug-cvs@gnu.org
> http://mail.gnu.org/mailman/listinfo/bug-cvs
>  

I sent this patch a long time ago to fix the same problem but even
though I begged I got no comments ;-).

I pass the repository name and each item generated from %{...}
as a seperate argument:

http://mail.gnu.org/archive/html/bug-cvs/2002-11/msg00092.html

I think the argument against such things is that it will break already
running scripts. Perhaps a command line argument should signal the
new format?

/Brian