yet another hash.c:312: findnode: Assertion `key != ((void *)0)' failed.

[Mike Sokolov]

We had this problem recurring for a long time and it didn't seem related to
the things people had previously reported (file capitalization differences
caused by windows / unix interoperation).  I finally loaded up gdb and
resolved to track this down.  There seemed to be a bug relating to a
malformed RCS file that got into our repository somehow - at any rate in
order to avoid the assertion in this case the following patch seems to be
called for:



*** commit.c.old        Tue Oct 14 22:15:26 2003
--- commit.c    Tue Oct 14 22:00:08 2003
***************
*** 920,926 ****
            {
                if (vers->tag == NULL)
                {
!                   if (finfo->rcs != NULL &&
                        !RCS_isdead (finfo->rcs, finfo->rcs->head))
                    {
                        error (0, 0,
--- 920,926 ----
            {
                if (vers->tag == NULL)
                {
!                   if (finfo->rcs != NULL && finfo->rcs->head != NULL &&
                        !RCS_isdead (finfo->rcs, finfo->rcs->head))
                    {
                        error (0, 0,


the contents of the RCS file that caused this were kind-of empty-looking:

head     ;
access   ;
symbols  ;
locks    ; strict;
comment  @# @;


desc
@@