Re: possible bugfix found (Re: checkout_repository-1)

[Paul Edwards]

"Mark D. Baushke" <mdb@cvshome.org> wrote in message 
news:mailman.2440.1067103981.21628.bug-cvs@gnu.org...
> Paul Edwards <kerravon@nosppaam.w3.to> writes:
>
> > "Mark D. Baushke" <mdb@cvshome.org> wrote in message 
> > news:mailman.2414.1067034757.21628.bug-cvs@gnu.org...
> > > The only thing I have seen is that the nightly testing for TRUNK on
> > > "Power_Macintosh Darwin" has problems with the remotecheck and bombs out
> > > during the checkout_repository-1 test.
> >
> > > So, you see in this particular case, it has lost the
> >
> > >    "cvs [checkout aborted]: "
> >
> > > text as a prefix to the error message and gained a "? CVSROOT" line.
> >
> > Can you apply the following patch and then show me the last few lines
> > of paul.txt to see if CVS at least thinks it is printing out the right
> > thing at that late stage.
>
> The patch as written will stop most of the tests due to "? paul.txt"
> showing up in the various directories when a checkout is being done.

Ok, /tmp/paul.txt then.

> All that said, I believe I have found the root-cause of the problem.

Great!

> The problem appears to be that both ${CVS_DIRNAME}/CVS and
> ${CVS_DIRNAME}/modules exist after the parseroot test is run.
>
> On MacOS X, /tmp/cvs-sanity/cvsroot and /tmp/cvs-sanity/CVSROOT are the
> same directory... so, later, when the checkout_repository test is run,
> it has problems. The solution would seem to be to run the parseroot test
> inside of a subdirectory.
>
> I still need to finish running my regression tests before checkin, but
> I think I have nailed this particular problem and I include the patch
> after my .signature.
>
> If it works and the all of the nightly sanity tests pass, maybe we
> can get Derek to release a new version of the feature branch.
>
> What I do not really understand is why this is not a problem in the
> cvs-1-11-x-branch which seems to have the same parseroot test as the
> trunk...

Also, why, when you run a range of tests, does this problem not
occur.

Also, why did the error line effectively get corrupted, saying
"? CVSROOT: failed to open directory"

instead of the prefix "cvs [checkout aborted]".

Why are two completely different error messages being
merged in that instance?

BFN.  Paul.