Re: possible bugfix found (Re: checkout_repository-1)

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Derek Robert Price <derek@ximbiot.com> writes:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Mark D. Baushke wrote:
> 
> | Paul Edwards <kerravon@nosppaam.w3.to> writes:
> |
> | >>What I do not really understand is why this is not a problem in the
> | >>cvs-1-11-x-branch which seems to have the same parseroot test as the
> | >>trunk...
> |
> | >Also, why, when you run a range of tests, does this problem not
> | >occur.
> |
> | There is only the ability to run a single test or to start at a
> | particular test and go to the end of all tests. Typically, I was backing
> | up only a few tests before the trouble and then running to completion
> | with no problems.
> 
> 
> Well, you can list all the tests you want to run, in order, on the
> sanity.sh command line, not just one test, but there is no easy way to
> specify a range other than test-to-end without listing each and every
> test.  That should be fixed after the Autotest overhaul.
> 
> What _was_ different between a run all the way through the suite and a
> run of a single test or a few tests?  

The difference was that the directory /tmp/cvs-sanity/cvsroot was used
to checkout CVSROOT/modules and so it had a local CVSROOT/CVS ... that
is:

   /tmp/cvs-sanity/cvsroot/CVS
   /tmp/cvs-sanity/cvsroot/modules
   /tmp/cvs-sanity/cvsroot/CVSROOT
   /tmp/cvs-sanity/cvsroot/CVS/Entries

The file /tmp/cvs-sanity/cvsroot/CVS/Entries contained an entry for
"/modules/1.2/day mon dd hh:mm:ss yyyy//" and "D" which is why the
"? CVSROOT" was being generated. It also contained a zero-length

   /tmp/cvs-sanity/cvsroot/CVS/Entries.Static
   /tmp/cvs-sanity/cvsroot/CVS/Repository

This file contained a "CVSROOT" line.

   /tmp/cvs-sanity/cvsroot/CVS/Root

This file contained a line with ":fork:/private/tmp/cvs-sanity/cvsroot/////"
because That is what the cvsroot used with the parseroot test used.

> I would have expected /tmp/cvs-sanity/cvsroot to be present
> regardless.

Yes, it was present. However, the presence of /tmp/cvs-sanity/cvsroot/CVS
caused cvs to go thru the 'cvs update' rather than 'cvs checkout' code path.

> If one of the other tests is leaving interfering cruft, it is possible
> that that should be fixed, as a separate issue.

I fixed it by forcing a checkout of CVSROOT do to be done in a subdirectory
so that it would int impact the cvsroot repository in the parseroot test.

> As for this breaking on the trunk and not 1.11.x, it broke immediately
> after one of my checkins to the trunk a few months back.  You should be
> able to figure out which if you can find a working archive of the
> test-results list.  Maybe I did something that causes some command to
> leave cruft behind that it shouldn't?

I thought you knew... 

The last good build of the TRUNK sent a message on 2003-06-12
10:59:46+0000 UTC.

The first break at the checkout_repository-1 test
occured on 2003-06-13 09:46:02+0000 UTC with 
Message-Id: <20030613094602.5709.qmail@mail.ximbiot.com> (included below)

The only significant patch in that time frame appears to be this one:

| 2003-06-12  Derek Price  <derek@ximbiot.com>
| 
|       * root.c (parse_cvsroot, local_cvsroot): Parse trailing '/'s off the
|       end of cvsroots.  Make arguments const.
|       * cvs.h: Update prototypes to match.
|       (Idea from Miles Zarathustra <shiva@aranyaka.org>.)

This is the same commit where the parseroot test for sanity.sh was added
to the repository.

It is less clear why the cvs1-11-x-branch did NOT break at the same
time.

> Regardless, the test suite does pass now on feature.  I'll roll the
> 1.12.2 release shortly.

Thanks Derek...

        -- Mark

                      ------- archive log -------

Date: 12 Jun 2003 20:38:23 -0000
From: dprice@cvshome.org
To: cvs@ccvs.cvshome.org
Subject:  CVS update: MODIFIED: src ...

  User: dprice  
  Date: 03/06/12 13:38:23

  Modified:    src      ChangeLog cvs.h root.c sanity.sh
  Log:
  * root.c (parse_cvsroot, local_cvsroot): Parse trailing '/'s off the
  end of cvsroots.  Make arguments const.
  * cvs.h: Update prototypes to match.
  (Idea from Miles Zarathustra <shiva@aranyaka.org>.)
  
  Revision  Changes    Path
  1.2471    +7 -0      ccvs/src/ChangeLog

  
http://ccvs.cvshome.org/source/browse/ccvs/src/ChangeLog.diff?r1=1.2470&r2=1.2471

  1.257     +2 -2      ccvs/src/cvs.h

  http://ccvs.cvshome.org/source/browse/ccvs/src/cvs.h.diff?r1=1.256&r2=1.257

  1.68      +16 -4     ccvs/src/root.c
  
  http://ccvs.cvshome.org/source/browse/ccvs/src/root.c.diff?r1=1.67&r2=1.68

  1.805     +17 -1     ccvs/src/sanity.sh
  
  
http://ccvs.cvshome.org/source/browse/ccvs/src/sanity.sh.diff?r1=1.804&r2=1.805
  
...actual patches elided from this copy of the message...
  
                  ------- First break message -------

Message-Id: <20030613094602.5709.qmail@mail.ximbiot.com>
Date: Fri, 13 Jun 2003 09:46:02 +0000
From: cvstest@ximbiot.com
To: test-results@ccvs.cvshome.org
Subject:  Nightly testing results for TRUNK (Power_Macintosh Darwin)

Nightly test results for Fri Jun 13 01:30:15 EDT 2003
Darwin fool.ximbiot.com 5.5 Darwin Kernel Version 5.5: Thu May 30 14:51:26 PDT 
2002; root:xnu/xnu-201.42.3.obj~1/RELEASE_PPC  Power Macintosh powerpc

Please send questions/comments to derek@ximbiot.com

/bin/sh /Network/Servers/empress/home/cvstest/cvs-nightly/src/sanity.sh 
`pwd`/cvs
This test should produce no other output than this message, and a final "OK".
(Note that the test can take an hour or more to run and periodically stops
for as long as one minute.  Do not assume there is a problem just because
nothing seems to happen for a long time.)
OK, all tests completed.
/bin/sh /Network/Servers/empress/home/cvstest/cvs-nightly/src/sanity.sh -r 
`pwd`/cvs
This test should produce no other output than this message, and a final "OK".
(Note that the test can take an hour or more to run and periodically stops
for as long as one minute.  Do not assume there is a problem just because
nothing seems to happen for a long time.)
FAIL: checkout_repository-1
make: *** [remotecheck] Error 1

             --------------- end of archive ---------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQE/nUN83x41pRYZE/gRAsDTAKDHPB+7MxBh0kgetwRmI3SmyKk8RwCgzoyM
xmlqubQg9u0+Of91LQd+2ts=
=ujO3
-----END PGP SIGNATURE-----