[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: Add support for CVS_USER environment variable

From: Derek Robert Price
Subject: Re: Patch: Add support for CVS_USER environment variable
Date: Thu, 04 Mar 2004 10:57:59 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

Hash: SHA1

M.E.O'Neill wrote:

>> and with test cases and documentation, as requested in the HACKING
>> file in the top level of the CVS source distribution!
> If I broke cvs hacking etiquette by just sending a patch, my
> apologies.  The message I'm getting here is that because I have
> neither the time nor inclination to act as a champion and maintainer
> for my patches, I shouldn't have bothered sending them in at all.
> Perhaps I should just submit bug reports and feature requests without
> any code?

Firstly, how much work you should or should not do when you discover a
"problem" with CVS you would like "fixed" depends how badly you want to
see the change appear in a CVS release.  At the moment there are only
three active and, for lack of a better wording, full-time CVS
developers, all with their own interests.

It is the long standing policy of this team that changes are not
accepted into CVS proper without accompanying documentation in
doc/cvs.texinfo and tests in src/sanity.sh.  As I mentioned twice
previously to you and many more times on this list, this is detailed
more fully in the HACKING file in the top level of the CVS source
distribution.  It is quite simply impractical to accept changes without
these features as changes without documentation and regression tests
tend to deteriorate rapidly as with the infamous PRESERVE_PERMISSIONS code.

If you don't have the time to do these for your patch, then thank you
very much for your work.  Perhaps someone on the development team will
deem it important enough to complete the test cases and documentation
for your changes, but we are all very busy people and can rarely get to
even all the obviously useful patch submissions we receive.  I am just
now getting to the edit -c patch that has been floating around for
something like three years and only a few weeks ago committed a patch of
my own I've been waitiing to commit for at least four years.

Failing developer interest, some other reader of this list may take an
interest and complete your documentation and test cases for you, but
that is even rarer.

Again, thank you for your patch!  I am sorry that informing you that the
three active CVS developers do not have an infinite amount of time on
their hands proved to be such a disappointment.  I am personally
particularly interested your -q/-Q patch for commit, but it is rare that
I can find the time to complete other people's work lately and it will
likely be at least several months before I have the luxury to spend much
time on that sort of thing again.


- --

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]