RE: CVS lockdir bug with repository symlinks

[Ambalu, Robert]

sorry, I did mean 1.11.2
I really wouldn't have time to do all these tests.  I can tell you that this
patch has been working for us at Goldman Sachs for over a year now.  We have
a 1000+ user base which make use of our repository daily.
I guess we'll most likely submit the patch to Project Issues and hope it
gets picked up...
Thanks
- Rob

-----Original Message-----
From: Derek Robert Price [mailto:derek@ximbiot.com] 
Sent: Tuesday, March 23, 2004 2:49 PM
To: Ambalu, Robert
Cc: 'lawrence.jones@eds.com'; 'bug-cvs@gnu.org'; Ngo, Hien
Subject: Re: CVS lockdir bug with repository symlinks


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ambalu, Robert wrote:

>Hey guys,
>Looks like I totally dropped the ball on this one and now its starting 
>to bite us since we cant update to the latest rev without a manual 
>merge
of the
>code.
>Can we revisit this bugfix?
>Please let me know if you need anything, here's the diff from lock.c in cvs
>rev 1.11.2.
>You'll probably have to #define realpath( path ) path to get this to
compile
>on NT though.


Did you really mean 1.11.2 and not 1.11.12?  1.11.2 is almost 2 years old.
I haven't tried applying your patch to a more recent release, but 2 years of
coding can lead to a lot of conflicts.

If you will provide a diff against a more recent version of CVS plus some
solid test cases for src/sanity.sh, including tests of locking with links in
the repository with and without LockDir set in CVSROOT/config, and perhaps
some documentation additions/corrections for doc/cvs.texinfo, I will
consider this patch.  I am interested in the functionality but I don't have
nearly enough time to do all the cruft needed for support & maintenance just
now.  Please see the HACKING file and perhaps TESTS for more specific
instructions regarding tests and documentation.

If you can't or won't provide tests and documentation, consider posting your
patch to the issues database on cvshome.org
<http://ccvs.cvshome.org/servlets/ProjectIssues> for tracking.  Then maybe
someone will find it and get around to coding the tests & doc eventually.

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAYJS2LD1OTBfyMaQRAr4wAJ0Sz6pdZtoJv0Jj0VlM8jtQdMmjXACgxO3n
qMeAzol/hCbkdG7z1/gAho0=
=eo4F
-----END PGP SIGNATURE-----