Re: update: patch: relative path bugs in cvs (client/server mode only)

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chris Bohn wrote:

>> Your patch was extremely mangled, with tabs converted to spaces and who
>> knows what else.  I read it and reimplemented it, mostly.
>
>
> This was only my second patch to cvs, and the first was just a week or
> so ago. Since going through the process, I've wondered why you take
> patches as diffs in text files.  That seems more complicated than
> needed and seems like more work for those who integrate the patch into
> the main trunk.  Why not accept patches as checked-in source on a
> branch of the file?  Tabs and all formatting will then certainly be
> maintained, and you can diff the files against whatever versions are
> most useful for you.  You don't have to be looking at context and/or
> line numbers to try and piece together where in a particular source
> file parts of a patch belong.  To me, it sounds like an easier way of
> getting at least the source code changes.  You could use tags to
> identify the patch, etc. for easy reference.


Because we don't have those kind of access controls on our CVS server
and I don't expect to see them anytime soon.  Most people don't seem to
have much problem keeping their patches unmangled.  At least, they
usually only seem to do it once or twice.

> Thanks for integrating it into the trunk; I look forward to a day when
> my company can just download the latest version and use it (for the
> past 5 years, the company has been using a locally modified version
> because of different issues that we had to work around).  The last two
> issues now appear ready to be in the next release.


Thanks for you submission.

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAbZYYLD1OTBfyMaQRAi7yAKCvHrCEzwxVzAcBhvCXduD1Tv9dUwCffY+t
Kzpj5fQxxoX/uQ+S/ymJ8hU=
=4FPR
-----END PGP SIGNATURE-----