Re: advisory locks patch

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Ogilvie <mmo9317bd@mailcan.com> writes:
> 
>     I think I've fixed the C89 problems (see latest minor update), but
> don't have an easily accessable older compiler to try it on.

You have indeed fixed the C89 problems.

With regard to my previous comments, I do understand that 'cvs edit'
presently only deals with locking a file regardless of version and that
'cvs edit -c' will do the same. 

I still believe it would be desirable to be able to lock a particular
branch of the file as a future addition to advisory locks in general.
I do not mean to imply that this enhancement needs to provide that
extension at this time.

I still believe that administrators of a cvs repository might find it
desirable that the -c behavior were the default for any 'cvs edit' and I
therefore suggest that it may be desirable to introduce a new
CVSROOT/config option to make that the default. 

The current patch under consideration which is found in attachment
http://sourceforge.net/tracker/download.php?group_id=20011&atid=320011&file_id=99545&aid=822306

for this issue:

http://sourceforge.net/tracker/index.php?func=detail&aid=822306&group_id=20011&atid=320011

applies with a slight amount of fuzz to the cvshome.org tree does
compile with a C89-based compiler. I have not tried running the
sanity.sh test as yet.

As has been mentioned, the patch is very large, but I think it does
introduce a missing functionality that could be useful to a fair number
of folks out there and I do not object to this patch being added.

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFBNEXn3x41pRYZE/gRAoNPAJ9YnxdVRDmEdlAcpm+FiUVDdGW9uACeNYUJ
cQLRvJXEo+e3wkDHiy14aFQ=
=lFtv
-----END PGP SIGNATURE-----