[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for CVS 1.11.17 and CVS 1.12.9 that allows for actions using s
Mark D. Baushke
Re: Patch for CVS 1.11.17 and CVS 1.12.9 that allows for actions using specific versions of CVSROOT/modules
Thu, 02 Sep 2004 11:34:39 -0700
-----BEGIN PGP SIGNED MESSAGE-----
Shane Turner <email@example.com> writes:
> Here at InfoInterActive, we've created a patch to allow us to better
> manage our modules. Our issue was that if you had to reproduce a
> build, there was no guarantee that the current version of a module
> fully encompassed what it did at the time the software was tagged. To
> rectify that we now tag CVSROOT/modules when we tag our software and
> wrote a patch that causes CVS to use a particular version of the
> modules file on checkout, export, etc. Now, if the CVSROOT/modules
> file it tagged at the time the software is built, we should now be
> able to re-create that build even if the module has been changed in
> the future.
You are addressing a problem that a number of folks consider a weakness
of the modules file.
However, as this is a new feature and not a remedy for an existing bug,
it will not be added to the cvs 1.11.x branch and will only be
considered for addition in the cvs 1.12.x feature branch. If possible,
patches should be made against the CVS top-of-tree from cvshome.org.
All that said, I have not looked closely at your patch yet (and I
probably won't have any time in the next few weeks myself, so if one of
the other maintainers gets to it first that would be fine with me).
I do have one comment/question for discussion...
Would it be reasonable to extend the patch to also deal with '-D' times
in conjunction with the -M ? So that if '-M branch' is used, then the
branched version of the modules file is used and if -D and -M are used,
then the version of the modules at that point in time on that branch are
Note: A CVSROOT/modules file that was not branched or tagged will also
need to do something reasonable given a '-M rev' flag.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
-----END PGP SIGNATURE-----