[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS Time Zone Bug

From: Chris Bohn
Subject: Re: CVS Time Zone Bug
Date: Tue, 07 Sep 2004 14:06:23 -0400
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040616

OK; while it was a pain to get through, here are the results:

The 1.12.9 source distribution doesn't build under Windows. After fixing a few of the errors, I looked at the source tree and found you applied many fixes submitted by Conrad so that it would build under Windows. After applying a few of them as I saw the updates in the head of the project and continuing to hit more, I eventually just copied the head of the ccvs project's Windows-NT directory to my 1.12.9 source tree (which resulted in the builds having version With that, and updated .mak files for some of the directories, it finally built. I wasted a lot of time with this. I think we should come up with a way of indicating when the "released" source doesn't build on a particular platform, and when the appropriate fixes have been made, it would be nice for a point release to be made so the source can be built on all platforms. Both would have saved me a lot of time, and just indicating the source wouldn't build under Windows would have also. That is a separate issue, but it really would be helpful.

After applying the patch you gave, it initially wouldn't build. I had to change all 'bool' references (standard only in C++) to 'BOOL'. Once that was fixed, I got errors indicating "Failed to retrieve modification time for xxx". I had to change filesubr.c from

if (GetUTCFileModTime (file, &sb->st_mtime))
if (!GetUTCFileModTime (file, &sb->st_mtime))

(just adding the '!' since true is returned on success). After doing that, it built and seems to fix the problem. I did notice that my 1.10 client in some cases puts the cvs\entries time off by an hour, so some files are still marked incorrectly as having changed (cvs stat fixes the time), but hopefully this is just a one time change since my understanding is that changing to/from DST will no longer make every file listed as having been changed (the way 1.10 does).

When do you expect to release a real build for this? I'd like to roll out the real version and not a custom version.


Derek Robert Price wrote:

Hash: SHA1

Chris Bohn wrote:

I can give it a try Tuesday.  When I tried building 1.12.9
yesterday, it wouldn't build.  I have .NET 2003 installed, and it
complained about the libcvs make file referencing
..\Windows-NT\un....h (I don't remember the exact file).  I have
access to a VC 6 install, so I was going to try it.  This is the
first time I have used the make file since it was updated to VC 6
format, but since I used it previously, I think I was running it
correctly (from the root directory).

Okay, if you encounter errors, please feel free to send them to the
list and CC me.  Occasionally I add macros, headers, and/or source
files on UNIX and they don't get included correctly on Windows until
someone notices and complains.  Once I see the error message I can
usually remember which files I added recently which might be causing
the problem, at which point the fix is usually a one or two liner.

I'm running Windows XP Pro, so I was using NTFS when I had this
problem, so I'm not sure what you said is accurate as to the fix
(fixing NTFS). One thing I did notice from my limited testing is
that it only seems to be a problem in cvs\entries.  A cvs log on the
file shows the correct times.  What I didn't test was what would
happen once DST changes again to know if cvs log still shows the
correct time.

Maybe I fixed it on Fat32 and not NTFS?  Maybe I missed the point
entirely?  Anyhow, the code I added now purports to deal with the
problem correctly.



- --

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]