Re: cvs co understands CVSROOT not understood by cvs up

[Alexander Taler]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

  Mark> I believe that 'localhost/tmp/mdb.testit should either not be legal, or
  Mark> should have the CVS/Root be the changed to be the canonical form of it.

  Derek> Personally, in a case like this, I would favor the logical minimum
  Derek> (host/path), since it does not actually exclude the nominally more
  Derek> human readable form containing colons or other "odd" symbols.

- From your responses I deduce an agreement that CVS should support
the degenerate localhost/var/cvs form of the CVSROOT.  Following
is a sanity.sh patch to 1.11 to exercise this case.

Alex

Index: src/sanity.sh
===================================================================
RCS file: /cvs/ccvs/src/sanity.sh,v
retrieving revision 1.752.2.133
diff -u -r1.752.2.133 sanity.sh
- --- src/sanity.sh     12 Sep 2004 14:50:16 -0000      1.752.2.133
+++ src/sanity.sh       21 Sep 2004 14:15:50 -0000
@@ -3789,6 +3789,29 @@
 Logging out of :pserver:$username@localhost:2401/dev/null
 $PROG logout: warning: failed to open $HOME/\.cvspass for reading: No such 
file or directory
 $PROG logout: Entry not found\."
+
+           if [ -n "$remotehost" ] ; then
+             # Test checking out and subsequently updating with some different
+             # CVSROOTs.
+
+             # A standard case, hostname:dirname.
+             rm -r CVSROOT
+             CVSROOT=${remotehost}:${CVSROOT_DIRNAME}
+             dotest parseroot-4-1 "${testcvs} -Q co CVSROOT"
+             cd CVSROOT
+             dotest parseroot-4-2 "${testcvs} -Q up"
+             cd ..
+
+             # A degenerate remote case, just the server name and the directory
+             # name, with no :'s to help parsing.  It can be mistaken for a
+             # relative directory name.
+             rm -r CVSROOT
+             CVSROOT=${remotehost}${CVSROOT_DIRNAME}
+             dotest parseroot-4-3 "${testcvs} -Q co CVSROOT"
+             cd CVSROOT
+             dotest parseroot-4-4 "${testcvs} -Q up"
+             cd ..
+           fi
          fi
 
          if $keep; then



- -- 
http://libcvs.cvshome.org/    Access CVS through a library. 
PGP:  ID: 0x23DC453B  FPR: 42D0 66C2 9FF8 553A 373A  B819 4C34 93BA 23DC 453B
The purpose of the minutes is not to record events, it is to protect people.
                -- Sir Humphrey Appleby
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (OpenBSD)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBUDhNTDSTuiPcRTsRAnQfAJ0VAZUcvy77aJrsuSpU10tDMj9sDgCeOkAh
Xq7je3VikIZRls5MOOjQeFE=
=EnCg
-----END PGP SIGNATURE-----