configure.in re#defines getpass twice

[Martin Neitzel]

>Submitter-Id:   net
>Originator:     Martin Neitzel
>Organization:  net
>Confidential:  no
>Synopsis:      configure.in re#defines getpass twice
>Severity:      serious
>Priority:      medium
>Category:      cvs
>Class:         sw-bug
>Release:       1.12.9.1
>Environment:
        System: IRIX sco 5.3 11091810 IP12 mips
        Commercial SGI cc compiler with -w2 ("take warnings seriously")

>Description:
        As is, the generated configure script will contain the sequence
        #define getpass gnu_getpass
        #define getpass cvs_getpass
        in various test programs.

        If cvs is configured to take warnings seriously, the configure
        run will not even complete but abort with a spurious "long long
        check failed".

>How-To-Repeat:
        Certainly on my old SGI Indigo with the commercial cc:
        sh configure CFLAGS=-w2

        Likely (unchecked) on any system with:
        sh configure CC=gcc CFLAGS="-Wall -Werror" ...

>Fix:

Since "gl_FUNC_GETPASS_GNU" already results in a anti-system #define,
there's no needd for the additional AC_DEFINE in configure.in.

Index: configure.in
===================================================================
RCS file: /cvs/ccvs/configure.in,v
retrieving revision 1.300
diff -u -r1.300 configure.in
--- configure.in        25 Sep 2004 19:10:25 -0000      1.300
+++ configure.in        1 Oct 2004 14:06:43 -0000
@@ -255,10 +255,6 @@
 dnl We always want to use the GNULIB getpass, so define its name to something
 dnl that won't conflict with system declarations.
 gl_FUNC_GETPASS_GNU
-AC_DEFINE([getpass], [cvs_getpass],
-  [We want to always use the GNULIB version of getpass which we have in lib,
-   so define getpass to something that won't conflict with any existing system
-   declarations.])
 
 #
 # End GNULIB stuff.