RE: Windows Build Broken: /ccvs/lib/ xgetwd.c, xgetcwd.c, xgetcwd.h

[Conrad T. Pino]

> From: Derek Robert Price
> 
> I just checked in a change that should fix the filesubr.c error.

I've confirmed the "filesubr.c" error is gone:

Linking...
libdiff.lib(xgetcwd.obj) : error LNK2001: unresolved external symbol _getwd
.\WinDebug\cvs.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.

cvs.exe - 2 error(s), 0 warning(s)

> The other one probably wants "HAVE_GETCWD" defined in
> windows-NT/config.h.in.in.

Doesn't look like a good idea to me.  The Windows/VC6 platform don't have
a "getcwd" function.  They have "_getcwd" instead:

http://msdn.microsoft.com/library/en-us/vccore98/HTML/_crt__getcwd.2c_._wgetcwd.asp

> In addition, you'll probably want to define HAVE_GETCWD_NULL to some
> sort of value in config.h.in.in as an optimization if you can, though
> undef is probably safe.

Microsoft's "_getcwd" function will accept NULL for first argument but doesn't
make a definate statement regarding zero or negative second argument values.

I'll do a test program to determine behaviour of (NULL, 0) argument case and
report back the results.

In the meantime, how do you want to bridge the "getcwd" to "_getcwd" gap?

> Cheers,

Ditto,

> Derek

Conrad