RE: CVS update: /ccvs/ - cvsnt.dsp, readlink.c, xreadlink.c

[Conrad T. Pino]

Hi Mark,

> From: Mark D. Baushke
> 
> > The compile error occurs because none of the "#include" files cited contain 
> > a
> > "typedef" declaration for the "size_t" identifier.
> 
> Hmmm... so, in which #include file do you see size_t ?

VC6 provide "size_t" declarations in these files:

        File Include\CRTDBG.H:
        38      typedef unsigned int size_t;

        File Include\DIRECT.H:
        75      typedef unsigned int size_t;

        File Include\MALLOC.H:
        69      typedef unsigned int size_t;

        File Include\MBSTRING.H:
        68      typedef unsigned int size_t;

        File Include\MEMORY.H:
        62      typedef unsigned int size_t;

        File Include\NATIVE.H:
        45      typedef unsigned int size_t;

        File Include\NEW.H:
        64      typedef unsigned int size_t;

        File Include\RPCNDR.H:
        194     typedef unsigned int size_t;

        File Include\SEARCH.H:
        62      typedef unsigned int size_t;

        File Include\STDDEF.H:
        93      typedef unsigned int size_t;

        File Include\STDEXCPT.H:
        42      typedef unsigned int size_t;

        File Include\STDIO.H:
        70      typedef unsigned int size_t;

        File Include\STDLIB.H:
        71      typedef unsigned int size_t;

        File Include\STRING.H:
        61      typedef unsigned int size_t;

        File Include\TIME.H:
        89      typedef unsigned int size_t;
        172     typedef unsigned int size_t;

        File Include\WCHAR.H:
        79      typedef unsigned int size_t;

>    <string.h>    /* historical location */

Yes, "size_t" declared.

>    <stdio.h>     /* historical location */

Yes, "size_t" declared.

>    <stddef.h>    /* C89 defined location */

Yes, "size_t" declared.

>    <sys/types.h> /* GNULIB seems to think it should be here */

No, "size_t" NOT declared.

> Looking more closely at the system, the windows-NT/config.h.in.in,
> windows-NT/config.h.in and windows-NT/config.h files should all do
> 
> /* Define to `unsigned' if <sys/types.h> does not define. */
> #define size_t unsigned
> 
> in order to 'fix' things... However, that will probably actually break
> the build until readlink() is removed from widows-NT/filesubr.c too...

I prefer avoiding "#define" if "#include" with correct "typedef" is
available and alternative solutions will also break the build.

Breaking the Windows build is no great concern to me.  We do it all the
time.  My contribution to CVS project is fixing it when we do.  I track
email to "cvs@ccvs.cvshome.org" and run test compiles accordingly.  I'm
usually 24 to 48 hours behind in fixing Windows build which is better
than before I was put on "cvs@ccvs.cvshome.org" list.

>       -- Mark

Conrad