bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

import.c: heisenbug detected


From: Frank Hemer
Subject: import.c: heisenbug detected
Date: Mon, 21 Feb 2005 18:21:15 +0100
User-agent: KMail/1.5.1

If NDEBUG is defined, import fails with an unspecific error. This happens with 
the 1.12.x and the 1.11.x tree.
Note that the linux build does not define NDEBUG by default. However the win 
build has it.

Find below a patch that fixes this issue:


Index: import.c
===================================================================
RCS file: /cvs/ccvs/src/import.c,v
retrieving revision 1.164
diff -u -r1.164 import.c
--- import.c    1 Feb 2005 22:20:06 -0000       1.164
+++ import.c    21 Feb 2005 17:13:45 -0000
@@ -229,8 +229,9 @@
      */
     {
        regex_t pat;
-       assert (!regcomp (&pat, "^[1-9][0-9]*\\.[1-9][0-9]*\\.[1-9][0-9]*$",
-                         REG_EXTENDED));
+       int ret = regcomp (&pat, "^[1-9][0-9]*\\.[1-9][0-9]*\\.[1-9][0-9]*$",
+             REG_EXTENDED);
+       assert(!ret);
        if (regexec (&pat, vbranch, 0, NULL, 0))
        {
            error (1, 0,


Regards,
Frank




reply via email to

[Prev in Thread] Current Thread [Next in Thread]