Re: 'cvs watch on' patch (was: Changing passwords for CVS Users (pserver protocol)]

[Derek Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim Hyslop wrote:

| Derek Price wrote:
|
|> The patch does what you said it would on stable, but something
|> else is wrong on feature.  The new watch6-2 test fails -
|> basically, the previous watch add appears to be failing without
|> reporting the error.  I've attached a revised patch, with the
|> failing tests (which, again, pass on stable).
|
|
| I've investigated, and watch6-2 appears to fail as a result of a
| different bug in feature. The commands "cvs watch [add/remove]"
| (with no files specified) no longer create the default entry in the
|  fileattr file.
|
| The test cases should pass on feature if you:
|
| sed 's/watch add/watch add .' sed 's/watch remove/watch remove .'
|
| I'll look into that other bug and see if I can track it down.
|

Nope.  I'm still getting the same failure after making your change:

$ src/sanity.sh src/cvs watch6
$ tail -4 check..log
PASS: watch6-1
grep: /tmp/cvs-sanity/cvsroot/watch6/subdir/CVS/fileattr: No such file
or directory
exit status was 2
FAIL: watch6-2


Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCHk0pLD1OTBfyMaQRAnTwAJ9Vz49cx5mMH0j5jgDK3ZSScN6JxACgkI4A
P+nbezeWBx9fCpr+3JBj3Lw=
=++lc
-----END PGP SIGNATURE-----