bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature request/ideas


From: Derek Price
Subject: Re: Feature request/ideas
Date: Fri, 25 Feb 2005 13:16:45 -0500
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark D. Baushke wrote:

| FYI...
|
| I think I have been able to reconstruct the original patch without
| linewrap... I don't know if I'll have time to really test it this
| week, so Derek may feel free to commit it if he thinks it is ready
| to go (modulo adding the missing src/ChangeLog and
| src/doc/ChangeLog entries).


Okay, looks like you got it Mark, except that some of the "commitid:"
lines still needed two spaces before them.

Frank, you're not quite hitting the preferred code formatting
described in the HACKING file.  If you could try to imitate that more
closely next time, it would be appreciated.  Also, I don't think it is
mentioned there, but we tend to prefer Xasprintf to xmallox/sprintf or
sprintfing to statically allocated strings.  Since Xasprintf
determines the length of the output string accurately and dynamically,
it is less prone to opening up memory overflow issues, exploitable or
otherwise.

Thanks for the patch!  I've committed it with a few minor changes re
the above, though I left most of the formatting alone for now since it
wasn't too far off.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCH2sZLD1OTBfyMaQRArytAJ9Xo0+PjWFzLnEvE3uGVDROyx1sswCg3og2
sJQfB/sHT1oYmMGy0ZnQJpQ=
=yh2r
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]