bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature request/ideas - final patch


From: Derek Price
Subject: Re: Feature request/ideas - final patch
Date: Thu, 07 Apr 2005 10:13:54 -0400
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Frank Hemer wrote:

| I have adapted most of the broken code, so again all tests pass.
| Unfortunately RCS_tag2rev() needs a special handling because it is
| responsible for adding rev. numbers (with magic) to the RCS file. I
| also had to fix part of the old code because for ex.
| RCS_nodeisbranch didn't properly detect a branch with plain
| revision numbers which lead to many workarounds. Your fix of
| admin.c broke parts of the existing code that wasn't tested by
| sanity.sh (symbolic tags with admin -b), this is fixed too. I
| started to add some more tests but still this is not sufficiant. I
| think it might make sense to put an intermediate commit to the
| newtags branch to make development less complex. Is it ok to send
| intermediate patches (tests pass but more work to be done)?


Yes.  It is ok to send intermediate patches.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCVUAhLD1OTBfyMaQRArURAJ9P7T1s6l632K6FeVPZY/wUtLYzkgCglBaM
nCo/dLct6sErMnstkpb1WV4=
=AScR
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]