[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: newtags

From: Frank Hemer
Subject: Re: newtags
Date: Tue, 19 Apr 2005 21:02:43 +0200
User-agent: KMail/1.5.1

On Tuesday 19 April 2005 20:41, Derek Price wrote:
> > I'd like to see my latest patch from 2005-04-08 18:03 beeing
> > commited to the newtags branch so I can continue working on it ...
> Sorry.  I ran the tests and saw them pass the other day but I had been
> having a hard time finding the time to review your most recent
> changes.  After a quick scan of your latest work, it looks to me like
> your changes are headed in the right direction.  Some of it is fairly
> obviously simplification.  I am still wondering whether there is a way
> to avoid handling magic numbers in so many locations - like maybe it
> should have been abstracted out by this portion of the code, but I
> haven't time for a full evaluation.
> Keep up the good work,

I just updated:-)

The number of locations is less than before starting the newtags branch - are 
you suggesting to also review and change the remaining locations? If so, I 
have the doc in mind saying magic numbers were added because of a performance 
gain. Is this still true or is that just a rcs-file parsing internal thing I 
don't have to bother about?

- The LinCVS Team -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]