Re: [PATCH] pagealign_alloc: don't loop endlessly

[Derek Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thorsten Glaser wrote:

>Derek Price dixit:
>
>>>Yes, that's why I was suggesting to print the error message to stderr
>>>so at least the client gets an idea about what happened and can slap
>>>the server administrator. CVS does this for quite some occasions, for
>>>example no space available in the server's temporary directory.
>>
>>Could you point me at the code that does this?
>
>
>Not out of the blue, I had to check. But it happens frequently
>when e.g. the OpenBSD anoncvs servers are overloaded.


And where is the code that does this?

>>How much good would sending the message to stderr really do? This
>>problem can only occur on the server, where sending to stderr, at best,
>>can only be reported to the client as an unrecognized protocol response,
>>if reported at all, once the network buffers are disabled (the network
>>buffer code is what is calling pagealign_alloc() here).
>
>
>No, it's actually displayed by the client (with my first diff).


I'm fairly certain it shouldn't be consistently displayed this way.  It
might ocassionally appear in the context of "Unrecognized response from
server: `some message on stderr'".

Can you provide me with a test case that reproduces this behavior?

Cheers,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCeQxpLD1OTBfyMaQRAgrVAJ9ZeNqHtuhH3dTjgZjAMLLpvr53qQCdFOWC
2Ccd7RA08CDF3ceEpfpmFtc=
=bics
-----END PGP SIGNATURE-----