[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Mark D. Baushke
Fri, 06 May 2005 09:09:37 -0700
-----BEGIN PGP SIGNED MESSAGE-----
To be considered for inclusion in a CVS FEATURE release, you should
provide changes to the doc/cvs.texinfo as well as at least a few test
cases (if you don't understand how to work with sanity.sh that is okay,
but we need a series of step-by-step commands that illustrate how to
verify that everything works with your new feature and how the new
feature interacts with existing features).
For this particular addition, I have a problem with how it works.
Assumption: I have a repository where there exists one directory called
Private that is 'read-locked' such that userA is able to checkout
directory Private and userB is not.
If userB starts a 'cvs checkout -d top .' command. What should you
expect to happen:
a) no files are checked out because Private will fail and that
'should' stop the checkout command from providing partial
b) all directories that are processed up to, but not including the
Private directory are checked out. However, any files that
would logically have been checked out of directories after
"Private" are not checked out because the directory traversal
will stop when "Private" is first reached.
c) all directories other than "Private" will be checked out of the
repository and the user will receive a "Lock Info failed" message
that they may or may not notice indicating that the "Private"
directory was not checked out.
With your current patch, I believe userB will observe behavior 'b',
but I am not sure if that is true or not.
It is not clear to me if behavior 'a' or behavior 'c' is the correct
behavior, but I believe behavior 'b' is not desirable.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
-----END PGP SIGNATURE-----
- lockinfo, Kendy Kutzner, 2005/05/06
- Re: lockinfo,
Mark D. Baushke <=