RE: Feature Branch Windows Build Broken - New GNULIB glob module

[Conrad T. Pino]

Hi Derek,

> From: Derek Price [mailto:derek@ximbiot.com]
>
> Well, basically.  I created the glob module myself and added it to CVS
> and Paul has been reviewing it and I've been correcting it in ways to
> make it compatible with GNULIB & GLIBC.

Cool.  Another budding published author in our midst. :)

> I can't comment on how lucky you were, but you did arrive at the correct
> solution.  :)

Thank you much appreciated.

> >I'm willing to commit the Windows build and "windows-NT/pwd.?" files.
> >What's your preference on who sends "glob_.h" patch to GNULib team?
>
> I'll do it.  It should slide into my ongoing discussion with Paul about
> this new module easily enough.
>
> >+#ifndef __restrict
> >+# define __restrict
> >+#endif
>
> This is not correct.  It should be
>
> #ifndef __restrict
> # define __restrict restrict
> #endif
>
> If the "restrict" keyword is not supported by MSVC, then in
> windows-NT/config.h.in.in, "restrict" should be defined to some
> variation of "__restrict", "__restrict__", "_Restrict", or empty.

I updated with the recent commit of the glob module and we have a
new warning on line 1184 of "lib/glob.c" file (see below) and the
"__restrict" change made looks fine.

> The rest of your patch looks fine.

OK, I'll have it committed fairly soon.

> Regards,

Ditto,

> Derek

Conrad
==========================================================
--------------------Configuration: libcvs - Win32 Debug--------------------
Performing Custom Build Step on .\glob_.h
        1 file(s) copied.
Compiling...
glob.c
h:\conrad\projects\cvs-1.12\lib\glob.c(1187) : warning C4133: ':' : 
incompatible types - from 'struct direct *' to 'struct dirent *'
h:\conrad\projects\cvs-1.12\lib\glob.c(1187) : warning C4133: 'initializing' : 
incompatible types - from 'struct dirent *' to
'struct direct *'
Creating library...
--------------------Configuration: libdiff - Win32 Debug--------------------
Creating library...
--------------------Configuration: cvsnt - Win32 Debug--------------------
Compiling...
find_names.c
H:\Conrad\Projects\cvs-1.12\src\find_names.c(338) : warning C4018: '<' : 
signed/unsigned mismatch
Linking...
LINK : LNK6004: .\WinDebug\cvs.exe not found or not built by the last 
incremental link; performing full link

cvs.exe - 0 error(s), 122 warning(s)
==========================================================