Re: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

[Derek Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

>Hi Derek,
>
>The latest "lib/glob.c" introduced new macros not addressed
>in the m4 stuff. Of interest are "WINDOWS32" and perhaps
>"__MSDOS__" as "#define" and "#undef" respectively.
>
>Should I be expecting an "m4" solution which means I edit


No.

>"windows-NT/config.h.in.in" or not which means I edit the
>"windows-NT/config.h.in.footer" instead?


This stuff was cut and pasted from the glibc glob.c file.  Isn't
__MSDOS__ defined automatically by some compilers?  Considering that I
cannot find WINDOWS32 in any of the glibc header files, I would expect
WINDOWS32 to be defined similarly.

Looking at the code that is switching on those symbols, it looks mostly
like directory stuff to allow C:/ style paths, so if it turns out not to
be defined by your compiler it should be pretty harmless to just define
one or the other for now there.  I'm not so sure about the CONVERT_D_INO
stuff and REAL_DIR_ENTRY stuff.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFClNzILD1OTBfyMaQRAuSaAKDfMOkgRHtBMgGWgDqIgtUS/WA1bACg8OYB
yCCGQzMwcmEGpQQ6SeW6iv4=
=oD74
-----END PGP SIGNATURE-----