[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: OpenBSD 3.6 sparc64 stable crash
From: |
Alexander Taler |
Subject: |
Re: OpenBSD 3.6 sparc64 stable crash |
Date: |
Tue, 31 May 2005 19:26:50 -0400 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Tue, 31 May 2005 19:26:43 EDT
Tue, 31 May 2005 19:26:30 EDT
Alex> Core was generated by `cvs'. Program terminated with signal 10, Bus
Alex> error.
Alex> #0 0x000000000014f148 in run_add_arg_p (iargc=0x7a8000,
Alex> iarg_allocated=0x7a8004, iargv=0x7a7ff8, s=0x293838 "diff") at
Alex> /home/cvstest/cvs-nightly-cvs1-11-x-branch/src/run.c:81 81 if (*iargc >=
Alex> *iarg_allocated)
Derek> Can you be a little more specific about the problem?
Not really, but I can provide a patch which fixes it. It
successfully passed make check, and even includes a ChangeLog.
Alex
Index: src/ChangeLog
===================================================================
RCS file: /cvs/ccvs/src/ChangeLog,v
retrieving revision 1.2336.2.377
diff -u -u -r1.2336.2.377 ChangeLog
- --- src/ChangeLog 28 May 2005 06:53:24 -0000 1.2336.2.377
+++ src/ChangeLog 31 May 2005 23:20:07 -0000
@@ -1,3 +1,9 @@
+2005-05-31 Alexander Taler <alex@0--0.org>
+
+ * rcscmds.c: Change type of call_diff_argc_allocated from int to
+ size_t, to match the prototype of run_add_arg_p(). This fixes a
+ bus error in OpenBSD 3.6 sparc64.
+
2005-05-27 Conrad T. Pino <Conrad@Pino.com>
* cvs.h: Replace "run_arg" function with "#define run_arg run_add_arg",
Index: src/rcscmds.c
===================================================================
RCS file: /cvs/ccvs/src/rcscmds.c,v
retrieving revision 1.52.4.6
diff -u -u -r1.52.4.6 rcscmds.c
- --- src/rcscmds.c 27 May 2005 16:25:11 -0000 1.52.4.6
+++ src/rcscmds.c 31 May 2005 23:20:07 -0000
@@ -76,7 +76,7 @@
static char **call_diff_argv;
static int call_diff_argc;
- -static int call_diff_argc_allocated;
+static size_t call_diff_argc_allocated;
static void call_diff_add_arg PROTO ((const char *));
static void call_diff_setup PROTO ((const char *prog,
- --
https://savannah.gnu.org/projects/libcvs-spec Access CVS through a library.
PGP: ID: 0x23DC453B FPR: 42D0 66C2 9FF8 553A 373A B819 4C34 93BA 23DC 453B
convince your customer that pserver access to a CVS server is, if not
*actually* the work of the devil, then pretty similar -- Derek Price
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (OpenBSD)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>
iD8DBQFCnPK6TDSTuiPcRTsRArPjAKCbPVx1Nicany0tWKIkJCCkOwtl4QCeI8A0
54UcXlN2ODjiAntxg7BhQtM=
=TG3C
-----END PGP SIGNATURE-----