[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Next Steps: CVS Import Bug - Please Respond

From: Derek Price
Subject: Re: Next Steps: CVS Import Bug - Please Respond
Date: Fri, 12 Aug 2005 13:20:17 -0400
User-agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)

Larry Jones wrote:

>I don't know that there's any need to lock the entire directory tree for
>import like we do for commit, directory-at-a-time locking like we do for
>tag should suffice and be simpler to implement.  (The main reason commit
>needs a tree lock is that it reads all the RCS files and caches the data
>before starting to do any writes, so you have to have locks in place for
>the entire operation.)

Import is closer to commit than to tag, and I like locking the whole
tree before import because it means that retrieving a snapshot of a
project by date is more likely to retrieve trees in consistent states,
and is usually possible with a little informed eye-balling when choosing
the date.  The end result is something closer to atomic writes even if
we aren't entirely atomic yet.

Locking a dir at a time might be fine on stable, and would certainly
prevent corruption, but I'd rather we go the whole hog on feature, if
possible.  In any case, I think it would be The Right Thing (tm).



Derek R. Price
CVS Solutions Architect
Ximbiot <http://ximbiot.com>
v: +1 717.579.6168
f: +1 717.234.3125

reply via email to

[Prev in Thread] Current Thread [Next in Thread]