[bug #14591] Disallow addition of directories which look like cvs lock dirs or files.

[Derek Robert Price]

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14591>

                 Summary: Disallow addition of directories which look like
cvs lock dirs or files.
                 Project: Concurrent Versions System
            Submitted by: dprice
            Submitted on: Mon 09/19/05 at 19:24
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
                 Release: 
           Fixed Release: None
   Fixed Feature Release: None

    _______________________________________________________

Details:

- As a robustness, when LockDir is not being used, it may
    be desirable to prohibit directories that look like cvs
    internal lock files.
    https://ccvs.cvshome.org/issues/show_bug.cgi?id=183


>From https://ccvs.cvshome.org/issues/show_bug.cgi?id=183:

Currently with CVS 1.11.15 (and I assume later versions too) it's possible
to
shoot oneself in the foot (if CVS has been configured to place locks in the
repo):

    $ mkdir "#cvs.lock"
    $ cvs add "#cvs.lock"
    Directory /foo/bar/#cvs.lock added to the repository
    $ cvs up
    cvs update: Updating .
    cvs update: [19:03:31] waiting for scop's lock in /foo/bar

I'm suggesting that CVSLCK would be a banned dir/file name.  Will attach a
patch.



------- Additional comments from Ville Skyttä Thu Jun 3 12:08:16 -0700 2004
-------

Created an attachment (id=82)
Disallow adding CVSLCK (against 1.12.8, untested but trivial: "should work")



------- Additional comments from Derek Price Thu Jun 3 12:21:19 -0700 2004
-------

Sounds like a plan.



    _______________________________________________________

Carbon-Copy List:

CC Address                          | Comment
------------------------------------+-----------------------------
ville.skytta@iki.fi                 | Ville is the original reporter and
patch submitter.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 09/19/05 at 19:24  Name: cvs-lock.patch  Size: 2.39KB   By: dprice
Ville's untested patch.
<http://savannah.nongnu.org/bugs/download.php?item_id=14591&item_file_id=2968>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14591>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/