RE: socket-client.c doesn't need to compile on UNIX.

[Conrad T. Pino]

I just updated and compiled.  The compile has the usual warnings and
we have a link error:

client.obj : error LNK2001: unresolved external symbol _socket_buffer_initialize

The full incremental build output is attached in "compile.txt" file.

> From: Derek Price [mailto:derek@ximbiot.com]
> 
> I've committed the attached patch.  I'm going to follow it shortly with
> the a harmless reformatting patch.  I would like to remove the lines
> below from socket-client.h, as I think whatever #defines SOCK_STRERROR
> to some other function than strerror should know what headers it needs
> and should already have included them where needed, but I am afraid of
> breaking the Windows build, so if you could verify that it is okay, when
> you get the chance, Conrad, I would appreciate it.
> 
> # if defined SOCK_ERRNO || defined SOCK_STRERROR
> #   ifdef HAVE_WINSOCK_H
> #     include <winsock.h>
> #   else /* No winsock.h */
> #     include <sys/socket.h>
> #     include <netinet/in.h>
> #     include <arpa/inet.h>
> #     include <netdb.h>
> #   endif /* No winsock.h */
> # endif
> 
> 
> Thanks,
> 
> Derek

compile.txt
Description: Text document