[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #4573] Fix for keyword expansion problem/mis-feature during commi

From: Rahul Bhargava
Subject: [patch #4573] Fix for keyword expansion problem/mis-feature during commit
Date: Fri, 4 Nov 2005 08:13:20 -0800
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Follow-up Comment #2, patch #4573 (project cvs):

Hi Derek -

You wrote, "Ignoring the user's action is almost certainly not the correct
course of action here".  But that is exactly what CVS is doing right now, if
you commit a change with just keyword content changed, CVS ignores's the user
intent after returning the keyword modified file to CVS user. This is not at
CHECKOUT time as you wrote but when the file is returned back to the user on
COMMIT. Clearly that violates the contract you are referring to? If the
intent is to honor user's action, then the CVS server is obligated to change
whatever the user specifes in the keyword line just like normal content? Can
they do that currently ? The answer is NO. The user can not change for
example the revision number, CVS server will over-write that on COMMIT (not
checkout). This completely baffles a CVS users as the revision is bumped up
but the changes are wiped out from user sandbox on COMMIT. How does this not
lead to ignoring the user's action?

If you read the patch description, the suggested behaviour is optional. If
the CVS user doesn't want to change the behaviour they don't have to. We
would request you to please reconsider your decision. 

Best Regards,
Rahul Bhargava


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]