[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Cvs-dev] Re: [Cvs-test-results] Build CVS (TRUNK) failed.

From: Mark D. Baushke
Subject: Re: [Cvs-dev] Re: [Cvs-test-results] Build CVS (TRUNK) failed.
Date: Thu, 15 Jun 2006 10:48:14 -0700

[Sorry about sending a reverse patch the first time around...]

Hi Folks,

The CVS project found a need to add the following patch to
lib/strtoimax.c in order to get compilation on Windows to work.

The basic problem is that there is an __int64 type and three conversion

char * _i64toa(__int64, char *, int);
char * _ui64toa(unsigned __int64, char *, int);
__int64 _atoi64(const char *);

but 'long long' is NOT available.

This means that HAVE_LONG_LONG is not defined and intmax_t
is indeed __int64, so sizeof(INT) is greater than sizeof (long int).

If you agree that the patch is reasonable, please install it.

        -- Mark

Index: strtoimax.c
RCS file: /sources/gnulib/gnulib/lib/strtoimax.c,v
retrieving revision 1.14
diff -u -p -r1.14 strtoimax.c
--- strtoimax.c 18 Apr 2006 17:20:47 -0000      1.14
+++ strtoimax.c 15 Jun 2006 17:47:10 -0000
@@ -69,7 +69,7 @@ strtoimax (char const *ptr, char **endpt
   if (sizeof (INT) != sizeof (long int))
     return strtoll (ptr, endptr, base);
-  verify (sizeof (INT) == sizeof (long int));
+  verify (sizeof (INT) >= sizeof (long int));
   return strtol (ptr, endptr, base);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]