bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_HEADER_DIRENT


From: Jim Hyslop
Subject: Re: AC_HEADER_DIRENT
Date: Fri, 07 Jul 2006 23:06:13 -0400
User-agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[Note: removing Paul Eggert and bug-gnulib while we hash out
CVS-specific details]

Derek R. Price wrote:
> It would be nice to simplify.  Does the attached patch do the trick?

It works (well, it compiles at least - I haven't tested it) with a few
minor tweaks. I think the simplest thing would be for me to apply the
tweaks then check it in.

One of the tweaks is that MSVC doesn't understand the 'restrict'
keyword. Either we need to remove the keyword from the declaration and
definition of readdir_r(), i.e. in the header file:

- -int readdir_r (DIR *, struct dirent *restrict, struct dirent **restrict);
+int readdir_r (DIR *, struct dirent *, struct dirent **);

(with corresponding changes in the .c file),

or we need to add

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

to the top of dirent.h

Which approach would be better?

- --
Jim Hyslop
Dreampossible: Better software. Simply.     http://www.dreampossible.ca
                 Consulting * Mentoring * Training in
    C/C++ * OOD * SW Development & Practices * Version Management
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEryElLdDyDwyJw+MRAk45AJsGFT2j1Yuj+h0JyFNswQPf4qcKkwCg51pp
SGMTfyBxiswB6qtxht2dhRc=
=mRBT
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]