Re: 1.11.22 and MSVC

[Sergei Antonov]

On 7/26/06, Mark D. Baushke <mdb@gnu.org> wrote:

> > > > BUG #1
> > > > line
> > > >     free (cvs_password);
> > > > in src/login.c
> > > > and line
> > > >  free (password);
> > > > in src/client.c
> > > >
> > > > both free the same buffer, so, when the
> > > > "login" command is being executed, "free
> > > > (cvs_password);" tries to free an already
> > > > freed pointer. Debug runtime checks in MSVC
> > > > catch this.
> > >
> > > Hmmm... on the other hand, there are other
> > > code paths that need the password returned by
> > > get_cvs_password to be freed. See the patch
> > > below. I don't have time to test this right
> > > now, so if you could rerun your test to see if
> > > it works, that would be great.
> >
> > Your patch fixes the problem. Thank you.
>
> Okay, I have committed the fix for this to the
> STABLE branch and I'll merge it into the FEATURE
> branch tomorrow.
>
> It would be great if you could describe how you
> tested it, so that I could try to come up with a
> test case for the sanity.sh tests.

I tested it in MSVC, so I guess it is not acceptable in sanity.sh.
But I'm pretty sure that valgrind (http://valgrind.org/) is able to
detect this kind of errors.

> > > > BUG #3
> > > > All .dsw and .dsp files must have \r\n line
> > > > ends instead of \n line ends. Without that
> > > > Visual Studio doesn't open them.
> > >
> > > They probably started life this way and had
> > > the line endings changed by checkout from a
> > > UNIX box because the files are not -kb in
> > > nature. If you checkout a copy of the
> > > cvs1-11-x-branch directly, I suspect things
> > > should work.
> >
> > I forgot to write that had got my sources from
> > cvs-1.11.22.tar.bz2.
>
> Hmmm... Yes, they are considered 'text' files at
> present, so they get the line ending needed by the
> client that does the checkout. Most of the time
> this will be a a machine that uses "\n" line
> endings rather than "\r" or "\r\n" line endings.
>
> I thought we might have had a .zip file of the
> sources for x86-woe in the
> ftp://ftp.gnu.org/non-gnu/cvs/source/ directory,
> but I guess that is no longer being done.
>
> > .dsp/.dsw files there have UNIX line endings, so
> > MSVC doesn't open them :(.
>
> MSVC is not being very liberal in what it accepts
> which is unfortunate. I would rather not make
> those .dsp and .dsw files be -kb if we can avoid
> it.
>
> If you wish, you could probably use a unix2dos
> program to do the conversion of most of the files
> that are in the distribution.
>
> If that is not possible, then I guess I'd suggest
> you may wish to consider doing your own cvs
> checkouts of cvs1-12-13a or cvs1-11-22 as an
> alternative.

Of course, I have replaced \n to \r\n. That never was a problem for me.
What I care is that poor Windows guys are going stumble on that. And
not everyone will be able guess that the problem is because of line
endings. Is it possible to do a preprocessing of .dsp/.dsw before
packing them into tar.bz2?