Re: build warnings in latest CVS build

[Mark D. Baushke]

Hi Jim,

Jim Salter <jsalterjim@earthlink.net> writes:

> Configure option: --enable-client ...
> 
> util.c: In function `finish_output':
> util.c:311: warning: implicit declaration of function `waitpid'
> add.c: In function `build_entry':
> add.c:946: warning: implicit declaration of function `fputs_unlocked'
> 
> Configure option: --enable-server ...
> 
> util.c: In function `finish_output':
> util.c:311: warning: implicit declaration of function `waitpid'
> add.c: In function `build_entry':
> add.c:946: warning: implicit declaration of function `fputs_unlocked'

Thank you for your report.

The problem with util.c was that diff/system.h needed for sys/wait.h to
be added to the AC_CHECK_HEADERS in configure.in to be certain that the
HAVE_SYS_WAIT_H macro defined to determine if it should include that
file to get waitpid. Regenerating configure should have fixed this one.

The problem with add.c was that the #include <assert.h> which may
include <stdio.h> was being performed before the #include "cvs.h" so
that the rename of fputs was not being properly handled for the
declaration. Moving the <assert.h> below the cvs.h include should fix it.

While I was at it, I found a few other warnings:

      - base.c     implicit declaration of function gnu_getline
      - filesubr.c implicit declaration of function setenv
      - server.c   implicit declaration of function vasprintf

The patch I have should fix all of those. I'll commit it when it
finishes running through my 'make check' probably sometime later this
weekend.

Please feel free to try it out on your own systems and let me know if it
works for you. You don't mention what kind of system you were using to
do your check compiles, so I don't know if I have it covered or not.

        Enjoy!
        -- Mark

pgpi_P03pL0Gt.pgp
Description: PGP signature