[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #17530] Updates which only affect sticky tags should not output 'U'

From: Derek Robert Price
Subject: [bug #17530] Updates which only affect sticky tags should not output 'U' status.
Date: Fri, 25 Aug 2006 20:42:02 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20060728 Firefox/


                 Summary: Updates which only affect sticky tags should not
output 'U' status.
                 Project: Concurrent Versions System
            Submitted by: dprice
            Submitted on: Friday 08/25/2006 at 20:42
                Category: Bug Report
                Severity: 2 - Minor
              Item Group: None
                  Status: Confirmed
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
                 Release: 1.11.22
           Fixed Release: None
   Fixed Feature Release: None



Per the notes in bug #17168, updates which only affect sticky tags but which
do not change file contents should not output a `U' status.

To demonstrate, `cvs up -rbranch && cvs up -A', with a branch that mirrors
the content of the trunk.

This should be possible simple to do in update_fileproc.  Have patch_file set
docheckout to -1 when there are no differences between the workfile and the
new version.  Then, in update_fileproc, when docheckout == -1, skip calling
server_updated and just abuse Checked-in response (perhaps via
server_checked_in()) to send the entry to the client, as is already done in
several other locations.

Unfortunately, this would really be an abstraction violation.  Classify_File
should return T_ENTRY or the like if only the entry should be updated, but to
do this would require some test checkouts, and to do that efficiently would
require caching the checkouts for later use by patch_file or whatever.  All
this would be a lot of work to get right.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]