[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #18147] Using -R makes pserver violate protocol

From: Jeffrey Hutzelman
Subject: [bug #18147] Using -R makes pserver violate protocol
Date: Mon, 30 Oct 2006 04:50:04 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041020 Firefox/1.0.5


                 Summary: Using -R makes pserver violate protocol
                 Project: Concurrent Versions System
            Submitted by: jhutz
            Submitted on: Monday 10/30/2006 at 04:50
                Category: Bug Fix (patch attached)
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
           Fixed Release: None
   Fixed Feature Release: None



When cvs is invoked with -R to treat the repository as read-only, it prints
out a message warning about the dangers of doing this with repositories to
which other users might write(*).  Unfortunately, it does this before the
command has been identified, with the result that when a server mode is in
use, the warning is emitted without encapsulation, which violates the

The attached patch defers the warning until after server_active has been
initialized, and omits it entirely in that case (doing this right would be
somewhat harder, and for little gain -- if the server admin has forced use of
-R, it seems safe to assume (s)he understands the consequences, and if the
command was 'server' as invoked by ext or fork, then the client should have
already printed the warning anyway.

(*) Really, this is somewhat overstated.  There is no danger of
    corrupting the repository or even the user's working
    directory.  True, an update might get only some changed files
    from a simultaneous commit, but this can easily be corrected
    by running the update again, and atomicity has never been
    CVS's strong suit.


File Attachments:

Date: Monday 10/30/2006 at 04:50  Name: cvs_readonly_warning.patch  Size:
911B   By: jhutz
Don't warn about a read-only repository when acting as server


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]