[bug #18147] Using -R makes pserver violate protocol

[Jeffrey Hutzelman]

URL:
  <http://savannah.nongnu.org/bugs/?18147>

                 Summary: Using -R makes pserver violate protocol
                 Project: Concurrent Versions System
            Submitted by: jhutz
            Submitted on: Monday 10/30/2006 at 04:50
                Category: Bug Fix (patch attached)
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
                 Release: 
           Fixed Release: None
   Fixed Feature Release: None

    _______________________________________________________

Details:

When cvs is invoked with -R to treat the repository as read-only, it prints
out a message warning about the dangers of doing this with repositories to
which other users might write(*).  Unfortunately, it does this before the
command has been identified, with the result that when a server mode is in
use, the warning is emitted without encapsulation, which violates the
protocol.

The attached patch defers the warning until after server_active has been
initialized, and omits it entirely in that case (doing this right would be
somewhat harder, and for little gain -- if the server admin has forced use of
-R, it seems safe to assume (s)he understands the consequences, and if the
command was 'server' as invoked by ext or fork, then the client should have
already printed the warning anyway.

(*) Really, this is somewhat overstated.  There is no danger of
    corrupting the repository or even the user's working
    directory.  True, an update might get only some changed files
    from a simultaneous commit, but this can easily be corrected
    by running the update again, and atomicity has never been
    CVS's strong suit.






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Monday 10/30/2006 at 04:50  Name: cvs_readonly_warning.patch  Size:
911B   By: jhutz
Don't warn about a read-only repository when acting as server
<http://savannah.nongnu.org/bugs/download.php?file_id=11103>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18147>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/