Re: Eclipse, cvs, and extssh

[Bruno Haible]

Mark D. Baushke wrote:
> PS: Below is an experimental (untested) patch to cvs 1.11.x (current
> top-of-tree sources) which would implement a CVS_SSH and SSH_DFLT for
> the :extssh: method. I'd like to know if it completely solves your
> problem or if I have managed to forget something.

It yields these warnings (with "gcc -Wall"):

client.c: In function 'send_modified':
client.c:4968: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
client.c: In function 'start_server':
client.c:4806: warning: 'cvs_rsh' is used uninitialized in this function

After I applied this additional patch, the resulting 'cvs' program works
fine inside Eclipse checkouts, regardless of $CVS_RSH.

Bruno


*** src/client.c.bak    2008-01-25 20:43:57.841475000 +0100
--- src/client.c        2008-01-25 20:47:39.369518250 +0100
***************
*** 4737,4743 ****
  
      if (root->method == extssh_method)
        cvs_rsh = env_cvs_ssh ? env_cvs_ssh : SSH_DFLT;
!     if (!cvs_rsh)
        cvs_rsh = env_cvs_rsh ? env_cvs_rsh : RSH_DFLT;
  
      if (!cvs_server)
--- 4737,4743 ----
  
      if (root->method == extssh_method)
        cvs_rsh = env_cvs_ssh ? env_cvs_ssh : SSH_DFLT;
!     else
        cvs_rsh = env_cvs_rsh ? env_cvs_rsh : RSH_DFLT;
  
      if (!cvs_server)
***************
*** 4803,4809 ****
  
      if (root->method == extssh_method)
        cvs_rsh = env_cvs_ssh ? env_cvs_ssh : SSH_DFLT;
!     if (!cvs_rsh)
        cvs_rsh = env_cvs_rsh ? env_cvs_rsh : RSH_DFLT;
  
      if (!cvs_server)
--- 4803,4809 ----
  
      if (root->method == extssh_method)
        cvs_rsh = env_cvs_ssh ? env_cvs_ssh : SSH_DFLT;
!     else
        cvs_rsh = env_cvs_rsh ? env_cvs_rsh : RSH_DFLT;
  
      if (!cvs_server)