[bug #26608] pserver logs errors with excessive priority

[anonymous]

URL:
  <http://savannah.nongnu.org/bugs/?26608>

                 Summary: pserver logs errors with excessive priority
                 Project: Concurrent Versions System
            Submitted by: None
            Submitted on: Mon 18 May 2009 06:31:27 PM UTC
                Category: Bug Report
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
           Fixed Release: None
   Fixed Feature Release: None

    _______________________________________________________

Details:

This bug was originally reported to Debian on September 5th, 2006: 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=386153

It doesn't look like it was corrected in the Ximbiot CVS, though.  I've
reproduced the bug report below, substituting my exact errors:

When a remote pserver operation is interrupted for some reason, cvs will get
a recursive error trying to tell the disconnected client that it has been
disconnected. This recursive error generates a series of syslog entries with
LOG_DAEMON|LOG_EMERG which is highly excessive for a simple client
disconnect.

A sample broadcast of the error message:

Message from syslogd@myhost at Mon May 18 14:13:17 2009 ...
myhost cvs[29626]: [ID 702911 daemon.emerg] cvs [checkout aborted]: flow
control EOF

Message from syslogd@myhost at Mon May 18 14:13:17 2009 ...
myhost cvs[29626]: [ID 702911 daemon.emerg] cvs [checkout aborted]: received
broken pipe signal

Message from syslogd@myhost at Mon May 18 14:13:17 2009 ...
myhost cvs[29626]: [ID 587406 daemon.emerg] error (1, 0) called recursively. 
Second message was:

Message from syslogd@myhost at Mon May 18 14:13:17 2009 ...
myhost cvs[29626]: [ID 233912 daemon.emerg] error (1, 0) called recursively. 
Original message was:

These messages are generated in src/error.c after the recursion_error: label
around 216. I would suggest that these syslog messages do not need to be any
higher than LOG_ERR, and could quite reasonably be even lower.

These errors were generated using cvs-1.12.13 pserver, configured as an
inetd-managed SMF service, on a Sun Fire V215 running Solaris 10.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26608>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/