bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

cvswrappers


From: bebbo
Subject: cvswrappers
Date: Wed, 15 Dec 2010 19:49:47 +0100

Hi there,

 

since I consider server side source code formatting as a good thing and SVN
does not support checkin hooks, I decided to give CVS a try and added a
cvswrapper:

 

                *.java -t '/usr/local/fmt/fmt.sh "%s" "%s"'

 

 

Next I detected that the ,-t' option is disabled, so I got the source and
build CVS from source.

 

After removing the lines which prevent ,-t' 

 

Index: src/wrapper.c

===================================================================

RCS file: /sources/cvs/ccvs/src/wrapper.c,v

retrieving revision 1.50

diff -u -r1.50 wrapper.c

--- src/wrapper.c             12 Sep 2007 17:27:25 -0000         1.50

+++ src/wrapper.c          12 Dec 2010 21:03:58 -0000

@@ -424,8 +424,8 @@

                   /* Before this is reenabled, need to address the problem
in

                      commit.c (see

 
<http://ximbiot.com/cvs/cvshome/docs/infowrapper.html>).  */

-                  error (1, 0,

-                                 "-t/-f wrappers not supported by this
version of CVS");

+//             error (1, 0,

+//                            "-t/-f wrappers not supported by this version
of CVS");

 

                    if(e.tocvsFilter)

                              free(e.tocvsFilter);

 

it started to work, giving me some error message which I could also remove
by adding a fix (which fixes a bug?):

 

Index: src/checkin.c

===================================================================

RCS file: /sources/cvs/ccvs/src/checkin.c,v

retrieving revision 1.62

diff -u -r1.62 checkin.c

--- checkin.c       16 Sep 2008 21:00:20 -0000         1.62

+++ checkin.c    12 Dec 2010 21:06:14 -0000

@@ -52,6 +52,7 @@

                              if (! existence_error (errno))

                                  error (1, errno, "cannot remove %s",
finfo->fullname);

                   rename_file (tocvsPath, finfo->file);

+                 tocvsPath = NULL;

               }

     }

 

Now everything works as intended.

 

Any clues why the ,-t' option is shut down?

 

Regards

 

Bebbo

 

 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]