bug-diffutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-diffutils] [PATCH] build: enable warnings and -Werror.


From: Jim Meyering
Subject: [bug-diffutils] [PATCH] build: enable warnings and -Werror.
Date: Sun, 22 Nov 2009 21:46:51 +0100

I've just pushed a few patches, leading up to this one:

>From e58efa5bd2f2fdab0aff6395b9d6c46e0db09fd3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 21 Nov 2009 17:45:33 +0100
Subject: [PATCH] build: enable warnings and -Werror.

* src/Makefile.am (AM_CFLAGS): Enable warnings and -Werror.
Set to this: $(WARN_CFLAGS) $(WERROR_CFLAGS)
* lib/Makefile.am (AM_CFLAGS): Similarly, but use this:
$(GNULIB_WARN_CFLAGS) $(WERROR_CFLAGS)
* configure.ac (GNULIB_WARN_CFLAGS): Don't turn off -Wuninitialized.
---
 configure.ac    |    1 -
 lib/Makefile.am |    2 ++
 src/Makefile.am |    1 +
 3 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 044237b..48f30b0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -115,7 +115,6 @@ if test "$gl_gcc_warnings" = yes; then
   # We use a slightly smaller set of warning options for lib/.
   # Remove the following and save the result in GNULIB_WARN_CFLAGS.
   nw=
-  nw="$nw -Wuninitialized"
   nw="$nw -Wunused-macros"
   nw="$nw -Wmissing-prototypes"
   nw="$nw -Wold-style-definition"
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 52c858d..a24d9aa 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -20,3 +20,5 @@ include gnulib.mk

 noinst_HEADERS += cmpbuf.h prepargs.h
 libdiffutils_a_SOURCES += cmpbuf.c prepargs.c
+
+AM_CFLAGS = $(GNULIB_WARN_CFLAGS) $(WERROR_CFLAGS)
diff --git a/src/Makefile.am b/src/Makefile.am
index b75e580..058a0e2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -22,6 +22,7 @@ noinst_HEADERS = system.h
 localedir = $(datadir)/locale

 AM_CPPFLAGS = -I../lib -I$(top_srcdir)/lib
+AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)

 LDADD = \
   ../lib/libdiffutils.a \
--
1.6.5.3.502.gc3e2e




reply via email to

[Prev in Thread] Current Thread [Next in Thread]