bug-diffutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-diffutils] bug#18857: bug#18857: floating point exception on invali


From: Paul Eggert
Subject: [bug-diffutils] bug#18857: bug#18857: floating point exception on invalid argument
Date: Mon, 27 Oct 2014 22:24:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

Tobias Stoeckmann wrote:
I don't see the need to adjust anything
except avoiding this special value.  I doubt that anyone ever needed
these large numbers.

Yes, it's hard to imagine anyone needing a tabsize that large. Still, the GNU policy is to avoid unnecessary limits, so it's better to make the limit as large as easily possible, which here would be SIZE_MAX - GUTTER_WIDTH_MINIMUM. Also, I see there are other ways the nearby code can overflow. Plus, we should put in a test case for this bug. So I installed the attached patch, which should address these issues. Thanks for reporting the problem.

Attachment: 0001-diff-fix-integer-overflow-problem-with-tabsize.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]