[bug #63605] Large number of UBSAN failures in test suite

[Sam James]

URL:
  <https://savannah.gnu.org/bugs/?63605>

                 Summary: Large number of UBSAN failures in test suite
                 Project: findutils
               Submitter: thesamesam
               Submitted: Sun 01 Jan 2023 03:43:35 AM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: Test suite failure
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 4.9.0
         Discussion Lock: Any
           Fixed Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 01 Jan 2023 03:43:35 AM UTC By: Sam James <thesamesam>
Hi,

I've been running Undefined Behaviour Sanitizer (UBSAN, -fsanitize=undefined)
on test suites for a bunch of core applications including findutils.

When building w/ ./configure CFLAGS="-O2 -ggdb3 -fsanitize=undefined"
LDFLAGS="-O2 -ggdb3 -fsanitize=undefined" & running make check, I get a very
large number of failures:
```
[...]
Running
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/testsuite/find.gnu/gnuand.exp
...
FAIL: gnuand.new-O0, tree.c:552:6: runtime error: member access within null
pointer of type 'struct predicate'
    #0 0x5599c6727e26 in consider_arm_swap
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:552
    #1 0x5599c6727e26 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:643
    #2 0x5599c67277a4 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:644
    #3 0x5599c6728e25 in build_expression_tree
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:1431
    #4 0x5599c67148f0 in main
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/ftsfind.c:789
    #5 0x7fd5a90c064f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
    #6 0x7fd5a90c0708 in __libc_start_main_impl ../csu/libc-start.c:381
    #7 0x5599c6714b54 in _start ../sysdeps/x86_64/start.S:115

FAIL: gnuand.new-O1, tree.c:552:6: runtime error: member access within null
pointer of type 'struct predicate'
    #0 0x5557507c1e26 in consider_arm_swap
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:552
    #1 0x5557507c1e26 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:643
    #2 0x5557507c17a4 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:644
    #3 0x5557507c2e25 in build_expression_tree
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:1431
    #4 0x5557507ae8f0 in main
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/ftsfind.c:789
    #5 0x7f0c3209664f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
    #6 0x7f0c32096708 in __libc_start_main_impl ../csu/libc-start.c:381
    #7 0x5557507aeb54 in _start ../sysdeps/x86_64/start.S:115

FAIL: gnuand.new-O2, tree.c:552:6: runtime error: member access within null
pointer of type 'struct predicate'
    #0 0x55c02e6e6e26 in consider_arm_swap
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:552
    #1 0x55c02e6e6e26 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:643
    #2 0x55c02e6e67a4 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:644
    #3 0x55c02e6e7e25 in build_expression_tree
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:1431
    #4 0x55c02e6d38f0 in main
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/ftsfind.c:789
    #5 0x7f6c93ac364f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
    #6 0x7f6c93ac3708 in __libc_start_main_impl ../csu/libc-start.c:381
    #7 0x55c02e6d3b54 in _start ../sysdeps/x86_64/start.S:115

FAIL: gnuand.new-O3, tree.c:552:6: runtime error: member access within null
pointer of type 'struct predicate'
    #0 0x55e8764dde26 in consider_arm_swap
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:552
    #1 0x55e8764dde26 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:643
    #2 0x55e8764dd7a4 in do_arm_swaps
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:644
    #3 0x55e8764dee25 in build_expression_tree
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/tree.c:1431
    #4 0x55e8764ca8f0 in main
/var/tmp/portage/sys-apps/findutils-4.9.0-r2/work/findutils-4.9.0/find/ftsfind.c:789
    #5 0x7fc84820f64f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
    #6 0x7fc84820f708 in __libc_start_main_impl ../csu/libc-start.c:381
    #7 0x55e8764cab54 in _start ../sysdeps/x86_64/start.S:115
[...]
```

I've attached the full build.log and find.sum. Let me know if more information
is needed. Testing was done with GCC 12.2.1_p20221231.

I noticed some of these issues (or similar ones) were reported before at
https://lists.endsoftwarepatents.org/archive/html/bug-findutils/2021-06/msg00005.html.






    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Sun 01 Jan 2023 03:43:35 AM UTC  Name: build.log  Size: 585KiB   By:
thesamesam

<http://savannah.gnu.org/bugs/download.php?file_id=54171>
-------------------------------------------------------
Date: Sun 01 Jan 2023 03:43:35 AM UTC  Name: find.sum  Size: 351KiB   By:
thesamesam

<http://savannah.gnu.org/bugs/download.php?file_id=54172>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63605>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/