Re: [Bug-freedink] Version strings for freedink-data

[Sylvain]

Hi,

Thanks for the feedback, and thanks for packaging FreeDink for
HomeBrew ^^

- Sylvain

On Sat, Jun 10, 2017 at 07:59:55PM -0700, Dj Padzensky wrote:
> Hi, Sylvain-
> 
> Thanks for getting back to me.
> 
> I see what you meant; VERSION and SOURCE_DATE_EPOCH aren’t really used in the 
> install process.  I’ve removed the munging.
> 
> As a sidenote, xargs on OS X doesn’t support the -r flag, so I had to patch 
> the Makefile, to use xargs -0, instead of xargs -0r.
> 
> Thanks again!
> 
> —Dj
> 
> 
> 
> > On Jun 10, 2017, at 5:09 AM, Sylvain <address@hidden> wrote:
> > 
> > Hi,
> > 
> > On Fri, Jun 09, 2017 at 03:41:50PM -0700, Dj Padzensky wrote:
> >> I’m building a package for freedink and freedink-data for HomeBrew,
> >> and I received the following feedback from the maintainers, which I
> >> thought I’d pass along.
> >> 
> >> In the Makefile for freedink-data, the build date is included in the
> >> version string.  This is probably not the best idea, since it means
> >> that my version of freedink-data will appear to be newer than yours,
> >> simply by virtue of the fact that I happened to type make after you
> >> did.  It might be a good idea to set your versions to static
> >> strings.  If you want the build date in there somewhere, then put it
> >> elsewhere, but part of the version string probably isn’t the best
> >> place.
> >> 
> >> In any case, for HomeBrew, I’m munging the date portion of the
> >> source directory, and using that in lieu of a build date.
> > 
> > I'm not sure why you need to fiddle with the date at all?
> > 
> > As a package maintainer, you get the latest official release at:
> >  http://ftp.gnu.org/gnu/freedink/freedink-data-1.08.20170409.tar.gz
> > (the git repo is the dev version and not suitable for packaging)
> > 
> > Then you install it with:
> >  make install
> > or possibly
> >  make install DESTDIR=$(pwd)/binary-package/
> > 
> > All of these do not involve dates AFAIK, date is only used when a new
> > official release is made (i.e. by me), or when trying to reproducibly
> > rebuild the -nosrc tarball.
> > 
> > Can you precise where the date is present for you ?
> > 
> > Cheers!
> > Sylvain