[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] update-po is too touchy
From: |
Akim Demaille |
Subject: |
Re: [bug-gettext] update-po is too touchy |
Date: |
Tue, 9 Oct 2018 09:36:23 +0200 |
Hi Bruno!
> Le 9 oct. 2018 à 09:26, Bruno Haible <address@hidden> a écrit :
>
> Hi Akim,
>
>> The reason is that update-po looks for ‘GNU @address@hidden to decide
>> whether to include ‘GNU’ or not in the header.
>
> You can override this decision by defining the variable PACKAGE_GNU
> in the Makevars file [1].
I completely missed that, thanks! However, my Makevars is generated
by gnulib’s bootstrap, and it seems that it offers no room for
PACKAGE_GNU:
if test $with_gettext = yes; then
# Create gettext configuration.
echo "$0: Creating po/Makevars from po/Makevars.template ..."
rm -f po/Makevars
sed '
/^EXTRA_LOCALE_CATEGORIES *=/s/=.*/= '"$EXTRA_LOCALE_CATEGORIES"'/
/^COPYRIGHT_HOLDER *=/s/=.*/= '"$COPYRIGHT_HOLDER"'/
/^MSGID_BUGS_ADDRESS *=/s|=.*|= '"$MSGID_BUGS_ADDRESS"'|
/^XGETTEXT_OPTIONS *=/{
s/$/ \\/
a\
'"$XGETTEXT_OPTIONS"' $${end_of_xgettext_options+}
}
' po/Makevars.template >po/Makevars \
|| die 'cannot generate po/Makevars'
I’ll send a proposal to address that.
>> So I suggest that, to cope with the classical convention on
>> the package names, po/Makefile.in.in now uses ‘grep -i’ instead
>> of simply grep.
>
> Makes sense. Will do. (I was thinking about 'GNU clisp' vs. 'GNU CLISP'
> in this context just yesterday.)
:)
>> Of course, it would be nice too, if git seems to be present,
>> to use ‘git grep’, and then fall back to grep.
>
> Well, the entire 'grep' thing is a heuristic. Now that there is a way
> to override the result of this heuristic, I won't add significantly
> more complexity to it. ‘git grep' could fail for a number of reasons...
Yes, PACKAGE_RUN is definitely a better option, thanks!