Re: [PATCH] po-mode.el: fontification improvements and more

[Eliza Velasquez]

Hello Bruno!  Thank you for your quick and helpful response!

> You can see in the git log that I removed support for XEmacs in 2019.
> Are there other non-GNU Emacs versions worth considering?
>
> Also in 2019, I removed support for Emacs versions < 22, because
>    "Emacs 22 is the oldest version still in use, see
>     <https://repology.org/project/emacs/versions>."
>
> From this URL, you can see that Emacs 23 is the minimum one can assume
> today. It's the version present in RHEL 6, which is still supported
> until 2024-06-30.

Understood.  I assumed that other non-GNU Emacs versions were supported
since I saw a leftover comment referencing something called Demacs.  I
spent some time today pruning everything away all the pre-Emacs 23
compatibility options in a separate patch.  I'll be sharing that one in
a separate thread shortly.

> From which Emacs version is this 'defcustom :local t' supported?

Good point!  It seems that it's not available in Emacs 23, so I'll have
to revise.

>> 4.  Add support for fontification of msgids and msgstrs based on the
>>     configurable major mode introduced above.
>> 
>> This is the most significant patch out of the four and by far the most
>> likely to break compatibility with very old/non-GNU Emacs.
>
> Then it needs to be tested. For testing with old versions, there are
> essentially two possibilities:
>   - Use an old distro in a VM; see the link above
>     <https://repology.org/project/emacs/versions>.
>   - Install older versions of GNU Emacs from source. I used the attached
>     command script for doing so.

Thank you for the advice.  I got Emacs 23 running in a CentOS 6 VM.
(How nostalgic!)  I'll be sure to carefully test these patches once I
rebase them on the aforementioned Emacs 23 patch.

> Just as a matter of code style, please quote like 'this', not like
> `this'.

Hmm, I see.  Unfortunately it seems like the general Emacs documentation
convention requires `this style' rather than 'this style' [1], and the
byte compiler/flymake lints get angry if you don't follow it.  However,
the page you linked did specify that it only applied to output of the
program, rather than internal documentation, so I don't think they're
necessarily at odds with one another.

[1] 
https://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation-Tips.html

-- 
Eliza