Re: gettext failing msgconv-3 and lang-c++

[Paul E Reimer]

Hello,

The file ./gettext-tools/gnulib-lib/math.h appears to be generated by make (overwriting any patch that was applied on from the previous incarnation of make) rather than configure.  Hence, I applied the patch to ./gettext-tools/gnulib-lib/math.in.h, which is where the diff file appears to have been generated:

patch math.in.h ~/tmp/math.h.diff
cd ../..
./configure --prefix=/Users/reimer/local
make -j1
cd gettext-tools/tests
make check TESTS=lang-c++

Works with no errors on the test:

> PASS: lang-c++
> ============================================================================
>         Testsuite summary for gettext-tools 0.22.4
> ============================================================================
>         # TOTAL: 1
>         # PASS:  1
>         # SKIP:  0
>         # XFAIL: 0
>         # FAIL:  0
>         # XPASS: 0
>         # ERROR: 0
> ============================================================================
>

So the lang-c++ is solved!

I will run the msgconv-3 tests soon, but my day job needs some attention now.

Thanks,

Paul

On 2/13/24 11:40, Bruno Haible wrote:

> Hi,
>
> Paul E Reimer wrote:
> > mco-test3.out is attached, as well as the console output as 
> > gettext-msgconv-3.log.
> >       
> Thanks. I need more test from you: Can you please run the attached
> program (you probably need to link it with '-liconv'), and report
> the output?
>
> > > * Regarding the lang-c++ failure:
> > >    Can you please try to
> > >      1. apply the attached math.h.diff,
> > >      2. run "make" again,
> > >      3. $ cd gettext-tools/tests
> > >         $ make check TESTS=lang-c++
> > >    Does this work?
> > >         
> > For this, I was surprised to see that gettext itself contains three 
> > different math.h files
> >
> > [10:24 reimer@CSI358562 gettext-0.22.4] find . -name math.h
> > ./libtextstyle/lib/math.h
> > ./gettext-tools/gnulib-lib/math.h
> > ./gettext-runtime/intl/gnulib-lib/math.h
> >
> > I assume that I should apply the patch to 
> > ./gettext-tools/gnulib-lib/math.h .
> >       
> Yes, that's the one that matters.
>
> > But this does raise a question as to 
> > why are there three?  Running diff on them shows that they are indeed 
> > all different, varying by various #if statements.
> >       
> Different parts of GNU gettext needs different sets of Gnulib modules.
>
> So, after applying the patch, does "make check TESTS=lang-c++" pass?
>
> Bruno
>
>