bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add option --file to gtags


From: Hideki IWAMOTO
Subject: Re: [PATCH] add option --file to gtags
Date: Wed, 03 Aug 2005 11:55:47 +0900

On Mon, 01 Aug 2005 00:50:18 +0900, Shigio Yamaguchi wrote...
> > This is revised version. 
> > 
> >  gtags/gtags.c       |   33 +++-
> >  gtags/manual.in     |    4
> >  libutil/Makefile.am |    2
> >  libutil/filelist.c  |  418 
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> +++
> >  libutil/filelist.h  |   27 +++
> >  libutil/global.h    |    1
> >  6 files changed, 480 insertions(+), 5 deletions(-)
> 
> It seems that filelist.c and find.c have large amount of common code.
> How about using the same find_xxx() interface for reading from file list?
> In fact, in the aspect on the call side, it should be seeing in the same.
> 
> For example,
> [open]
>       find_open(flag) flag == USE_FIND or USE_FILELIST
>     or
>       find_open()
>       find_open_filelist()
> [read]
>       find_read()
> [close]
>       find_close()
> 

This is revised version. I chose adding find_open_filelist().

 gtags/gtags.c   |   25 +++++++++-
 gtags/manual.in |    4 +
 libutil/find.c  |  131 +++++++++++++++++++++++++++++++++++++++++++++++++++++---
 libutil/find.h  |    1
 4 files changed, 152 insertions(+), 9 deletions(-)

----
Hideki IWAMOTO  address@hidden

Attachment: gtags-file4.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]