Re: vim integration QuickFix bug in global-5.6

[Shigio YAMAGUCHI]

Hello Geoffrey,

> After running gtags on a source code tree, I start up vim (version
> 6.3).  In it I enter a :Gtags command.  I expect a QuickFix window to
> open, with the first item in the list to be opened in the edit window.  
> 
> The QuickFix window opens, but the items don't appear to be formatted
> correctly.  I expect something like:
> 
>  src/foo.c|18| bar
> 
> But instead they are listed like:
> 
>  || bar src/foo.c   #define bar 10
> 
> Also, no file is opened in the edit window, no doubt as a result of
> this strange listing format.
> 
> Sorry I don't have time to fix this bug.  I hope this report is
> useful.  I've gone back to global-4.8 which works fine.  I don't know
> where in the 5.x release squence this bug was introduced.
> 
> Geoffrey

Thank you for your report. It is surely useful,

The -t option of global(1) didn't work correctly.
It seems this bug was introduced in GLOBAL-5.4.
Here is a patch for it.

Index: libutil/pathconvert.c
===================================================================
RCS file: /sources/global/global/libutil/pathconvert.c,v
retrieving revision 1.14
diff -c -r1.14 pathconvert.c
*** libutil/pathconvert.c       5 Jul 2007 06:52:04 -0000       1.14
--- libutil/pathconvert.c       27 Jul 2007 14:35:48 -0000
***************
*** 253,259 ****
                fputc('\t', cv->op);
                fputs(convert_pathname(cv, path), cv->op);
                fputc('\t', cv->op);
!               fputs(rest, cv->op);
                break;
        case FORMAT_CTAGS_XID:
                fputs(gpath_path2fid(path, NULL), cv->op);
--- 253,259 ----
                fputc('\t', cv->op);
                fputs(convert_pathname(cv, path), cv->op);
                fputc('\t', cv->op);
!               fprintf(cv->op, "%d", lineno);
                break;
        case FORMAT_CTAGS_XID:
                fputs(gpath_path2fid(path, NULL), cv->op);
--
Shigio YAMAGUCHI <address@hidden> - Tama Communications Corporation
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3