bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

--from-here and --literal options do not interact


From: Jonathan Jacobs
Subject: --from-here and --literal options do not interact
Date: Wed, 20 Sep 2017 12:38:39 +0200

Good day,

In an attempt to improve support in the emacs library, ggtags, for
symbols named with lisp conventions such as "earmuffs" (surrounded by
asterisks, such as *some-variable*) I noticed that the handling for
the --from-here option does not interact with the --literal option:

$ global -v --result=grep --color=always --path-style=shorter
--from-here=77:emulator/beam/erl_process.c -x --literal -- '*ok*'
global: regular expression is not allowed with the --from-here option.

The man page doesn't go into any detail other than to say "Regular
expression is not allowed for pattern." However the intent of the
--literal option is to indicate that the search term is in fact not a
regular expression.

I've attached a patch that I think might enable the use of --literal
with --from-here, it seems the rest of the code in this path will
treat it literally without additional code although I lack the
expertise required to confirm that.

Regards,
Jonathan Jacobs

Attachment: literal_from_here.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]