[Bug-gnu-arch] [bug #4953] minor bugs in cmd-archive-mirror

[nobody]

=================== BUG #4953: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4953&group_id=4899

Changes by: Tom Lord <address@hidden>
Date: Fri 08/29/2003 at 21:21 (US/Pacific)

            What     | Removed                   | Added
---------------------------------------------------------------------------
              Status | Open                      | Feedback


------------------ Additional Follow-up Comments ----------------------------
cmd-archive-mirror.c has changed recently -- 

could you please update your patch against the

latest sources?



> I also discovered that the arch_archive_mirror function

> doesn't print a warning if the specified limit doesn't

> exist in the source archive. Is this a bug? 



Arguably, sure.



-t





=================== BUG #4953: FULL BUG SNAPSHOT ===================


Submitted by: jmccarty                Project: GNU arch -- a revision control 
system
Submitted on: Mon 08/25/2003 at 14:20
Category:  tla                        Severity:  5 - Major                  
Bug Group:  bug                       Resolution:  None                     
Status:  Feedback                     Release:  tla--devo--1.1--patch-131   
Fixed Release:                        Merge Request?:  yes -- merge from my 
archive
Your Archive Name:  address@hidden Archive Location:  
http://complex.dyndns.org:8000/~jason/address@hidden
Assigned to:  None                    

Summary:  minor bugs in cmd-archive-mirror

Original Submission:  archive-mirror doesn't accept a lone limit argument, 
contrary to what I would expect from the help output. Also, commands of the 
form "tla archive-mirror archive-name limit-spec garbage-text" don't trigger an 
error message.



I've fixed these by rewriting the archive and limit determination code in 
cmd-archive-mirror.c. It should now match the behavior described by the help 
output exactly. I believe that my changes should make future enhancement of the 
limit argument easier as well (being more straight-forward than the original 
code). My changes are in tla--devo--1.1--patch-6 in the listed archive.



In the process, I also discovered that the arch_archive_mirror function doesn't 
print a warning if the specified limit doesn't exist in the source archive. Is 
this a bug?



Please note that I will be unable to send or receive email for an indeterminate 
period of time, maybe a day or two (hurray for the sysadmin!).

Follow-up Comments
*******************

-------------------------------------------------------
Date: Fri 08/29/2003 at 21:20       By: tomlord
cmd-archive-mirror.c has changed recently -- 

could you please update your patch against the

latest sources?



> I also discovered that the arch_archive_mirror function

> doesn't print a warning if the specified limit doesn't

> exist in the source archive. Is this a bug? 



Arguably, sure.



-t



-------------------------------------------------------
Date: Fri 08/29/2003 at 14:34       By: jmccarty
I realized that this bug applies to tla 1.0 as well, so you might consider 
applying my patch there too. Even though it changes the syntax accepted by 
archive-mirror, it only changes it to match the syntax specified by -H.



Also, my email is working fine now.


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4953&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/