bug-gnu-arch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-gnu-arch] [bug #5573] includes in multi-tree projects


From: nobody
Subject: [Bug-gnu-arch] [bug #5573] includes in multi-tree projects
Date: Sat, 27 Sep 2003 18:27:35 -0400
User-agent: Mozilla/4.76 [en] (X11; U; FreeBSD 3.0-RELEASE i386)

=================== BUG #5573: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5573&group_id=4899

Changes by: Tom Lord <address@hidden>
Date: Sat 09/27/2003 at 15:27 (US/Pacific)

            What     | Removed                   | Added
---------------------------------------------------------------------------
              Status | Open                      | Feedback


------------------ Additional Follow-up Comments ----------------------------
Could you please make some cleanups to this?



In particular:



There is no need for the type `struct arch_file_list': a

rel_table or assoc_table will do just as well.



The parameters to arch_read_config should not need to

change.   Instead, arch_read_config can be a wrapper

function that calls arch_read_config_internal (a staticly

declared function) with extra parameters.



The particular include syntax is an interesting idea but

won't quite cut it, i'm afraid.   The problem is:  what if 

I have a subdir named "include"?   The syntax you chose 

might break some existing configs, and will lead to

confusing errors in future configs.



Minor formatting issues.... Please:



put a space after `for' but not after the '('.  



put spaces around '=' in assignments.



put a space between the function name and the '(' in

function calls.  Do not put a space after the '('.



put spaces around the '==' in comparisons -- around all

binary operators in general.



put a blank line between local variable declarations and the

rest of the code in the block



don't put a space before ')' in an `if'







=================== BUG #5573: FULL BUG SNAPSHOT ===================


Submitted by: cehteh                  Project: GNU arch -- a revision control 
system
Submitted on: Thu 09/25/2003 at 10:17
Category:  tla                        Severity:  5 - Major                  
Bug Group:  small feature idea        Resolution:  None                     
Status:  Feedback                     Release:                              
Fixed Release:                        Merge Request?:  yes -- merge from my 
archive
Your Archive Name:  address@hidden Archive Location:  
http://cehteh.homeunix.org/arch/cehteh000
Assigned to:  None                    

Summary:  includes in multi-tree projects

Original Submission:  address@hidden/tla--devo--1.1--patch-1

    added 'include' directive to multi-tree config files

address@hidden/tla--devo--1.1--patch-2

    fixed tracker and somewhat tested



docs at:

http://cehteh.homeunix.org/pipawiki/HowToSetupArch_2fHowToSetupMultiTreeProjects



cya Christian

Follow-up Comments
*******************

-------------------------------------------------------
Date: Sat 09/27/2003 at 15:27       By: tomlord
Could you please make some cleanups to this?



In particular:



There is no need for the type `struct arch_file_list': a

rel_table or assoc_table will do just as well.



The parameters to arch_read_config should not need to

change.   Instead, arch_read_config can be a wrapper

function that calls arch_read_config_internal (a staticly

declared function) with extra parameters.



The particular include syntax is an interesting idea but

won't quite cut it, i'm afraid.   The problem is:  what if 

I have a subdir named "include"?   The syntax you chose 

might break some existing configs, and will lead to

confusing errors in future configs.



Minor formatting issues.... Please:



put a space after `for' but not after the '('.  



put spaces around '=' in assignments.



put a space between the function name and the '(' in

function calls.  Do not put a space after the '('.



put spaces around the '==' in comparisons -- around all

binary operators in general.



put a blank line between local variable declarations and the

rest of the code in the block



don't put a space before ')' in an `if'






CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5573&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]